Allow duplicating an entity with an invalid PhysObj #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regular duplicator allows the same thing and it doesn't cause any problems. Made this PR to solve compatibility with addons like Half-Life 2 Tools
|
It seems I have foreseen everything, but an extra review would definitely help |
|
Need to make sure the PhysicsObjects table is created correctly when there's no physics objects. |
|
What do you mean by this? But I think it can be implemented better, but I implemented it just to make it work, because I don't know the structure of advdupe deeply |
|
Was referring to this, but it looks like it should work fine. https://github.com/wiremod/advdupe2/blob/master/lua/advdupe2/sv_clipboard.lua#L189-L204 |
|
PhysObj just will be invalid and ignored then |
thegrb93
approved these changes
Jun 9, 2025
wrefgtzweve
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regular duplicator allows the same thing and it doesn't cause any problems. Made this PR to solve compatibility with addons like Half-Life 2 Tools