8000 Add a webapp url field to email domain registration (2) by supersven · Pull Request #4562 · wireapp/wire-server · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a webapp url field to email domain registration (2) #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

Add a webapp url field to email domain registration (2) #4562

merged 3 commits into from
May 5, 2025

Conversation

supersven
Copy link
Contributor
@supersven supersven commented May 2, 2025 •
edited
Loading

PUT /i/domain-registration and GET /i/domain-registration (both are internal endpoints used only by Stern) are changed in their payloads:

  • backend_url becomes config_url in a new backend field / object.
  • The webapp_url field is new.

Old payload:

{
 "backend_url": "{url}",
...
}

New payload:

{
 "backend": {
   "config_url": "{url}",
   "webapp_url": "{url}"
  },
...
}

This change of the payload has also been documented here: https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/1570832467/Email+domain+registration+and+configuration#API-changes

Because we don't have system tests for Stern, I also made a quick manual smoke test: Checked that the redirect URL can still be configured and fetched.

Ticket: https://wearezeta.atlassian.net/browse/WPB-17032

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 2, 2025
@supersven supersven force-pushed the sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_2 branch from 5d9484d to 905428d Compare May 2, 2025 16:32
@supersven supersven force-pushed the sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_2 branch from 905428d to 6d1d2fc Compare May 2, 2025 17:56
@supersven supersven force-pushed the sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_2 branch from f69069b to 96cd4b9 Compare May 5, 2025 09:09
@supersven supersven marked this pull request as ready for review May 5, 2025 10:08
@supersven supersven requested review from a team as code owners May 5, 2025 10:08
pcapriotti
pcapriotti approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor
@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but what's the deal with domainRedirectS 8000 chemaV8? Is it even being used anymore?

@supersven
Copy link
Contributor Author

Looks good to me, but what's the deal with domainRedirectSchemaV8? Is it even being used anymore?

Thanks, @pcapriotti 👍

domainRedirectSchemaV8 is still used by this endpoint: https://github.com/wireapp/wire-server/blob/sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_2/libs/wire-api/src/Wire/API/Routes/Public/Brig/DomainVerification.hs#L428-L428

domainRedirectSchemaV8 renders the old payload:

{
  "backend_url": "<url>"
... 
}

And, domainRedirectSchema (without version suffix in the name) renders:

{
  "backend": {
    "config_url": "<url>",
    "webapp_url": "<url>"
  }
... 
}

@supersven supersven merged commit 84e3e3f into develop May 5, 2025
8 checks passed
@supersven supersven deleted the sventennie/WPB-17032_add_webapp_url_to_email_domain_reg_2 branch May 5, 2025 14:31
@supersven supersven mentioned this pull request May 12, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supersven @pcapriotti @zebot
0