8000 Rsync instead of clone by daladim · Pull Request #205 · winfsp/sshfs-win · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rsync instead of clone #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Rsync instead of clone #205

wants to merge 3 commits into from

Conversation

daladim
Copy link
Contributor
@daladim daladim commented Jun 7, 2020 •
edited
Loading

This PR only adds a commit on top of the (already-existing) daladim:build_documentation PR.
I have created a distinct PR since I am sure this commit is really sensible, please review it and tell me what you think about it.

The provided Makefile would not work on my Cygwin installation. For some reason, using git clone from the sshfs submodule does not work (although it does on WSL). Replacing it with rsync works correctly.

Here is the error I had:

$ make
mkdir -p .build/x64/src
git clone /tmp/sshfs-win/sshfs .build/x64/src/sshfs
fatal: repository '/tmp/sshfs-win/sshfs' does not exist
make: *** [Makefile:99 : .build/x64/status/clone] Error 128

daladim added 3 commits June 7, 2020 22:38
@daladim
README: added a 'Build' section
1818968
@daladim
Makefile: Using the --binary switch to patch
10a0f75 
This would otherwise fail when building on Windows/Cygwin
@daladim
Makefile: Using rsync rather than git clone
d003db7 
For some reason, git-cloning this way would work on WSL, but not on Cygwin.
Using rsync here works (however, this will not check the working tree of this submodule has not been edited since the expected commit)
@billziss-gh
Copy link
Collaborator

I am not so sure about this one.

This repo contains sshfs as a submodule, which means that you must make sure to initialize it. (e.g. by using git clone --recurse-submodules during cloning or git submodule update --init sshfs at a later time).

@billziss-gh
Copy link
Collaborator

BTW, I believe the original problem that triggered this PR happens when you use Git-for-Windows from Cygwin.

@daladim
Copy link
Contributor Author
daladim commented Jun 14, 2020

You are absolutely right. I have uninstalled Git-for-Windows from the control panel, installed the git Cygwin package, and the original Makefile now works like a charm. I have updated (yet another) PR to write it in the documentation.

Thanks for your support

@daladim daladim closed this Jun 14, 2020
@daladim daladim mentioned this pull request Jun 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daladim @billziss-gh
0