p2p: During block download, adjust pindexLastCommonBlock right away #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to calculate nWndowEnd better. Before, it would be calculated based on an old pindexLastCommonBlock, which could result in blocks not requested for download that could have been requested, and peers being wrongly marked as staller.
This reverts commit 49d569c which introduced extra logic for when a snapshot was loaded. With the previous commit, this is not longer necessary because the more general logic of advancing pindexLastCommonBlock also covers this case.
getpeerinfo provides a list of blocks that are inflight, which can be used instead.
This test (which would fail without the previous commit) checks that after the stalling block was received, we don't incorrectly mark another peer as a staller immediately.
ca1d011 to
4fb5c73
Compare
c08c8ae to
bb5aa0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x