support for longtext data in mysql #281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢PR。麻烦提交的代码保持和原有代码风格一致！ |
Barenboim
reviewed
Apr 22, 2025
| @@ -195,6 +195,10 @@ wfrest::Json mysql_concat_json_res(WFMySQLTask *mysql_task) | |||
| { | |||
| row.push_back(arr[i].as_ulonglong()); | |||
| } | |||
| else | |||
| { | |||
| row.push_back(arr[i].as_binary_string()); | |||
There was a problem hiding this comment.
@chanchann 这里会不会有编码问题？可能拼接出来的json不合法吗。
There was a problem hiding this comment.
判定数据类型时 longtext 类型被判定为 MYSQL_TYPE_BLOB，潜在问题是除了 if 判断的数据类型之外其余类型都要走这个分支
There was a problem hiding this comment.
主要问题是，如果非utf-8编码的数据，是不能这样直接装进JSON的。而且这里Json解析器也不清楚数据是什么编码，也没办法做转换。我怀疑这里没有加binary string的数据，原因可能是chanchan觉得编码问题解决不了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.