8000 Add horizontal scroll and link to open board to My Cards by helioguardabaxo · Pull Request #3469 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add horizontal scroll and link to open board to My Cards #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add horizontal scroll and link to open board to My Cards #3469

wants to merge 2 commits into from

Conversation

helioguardabaxo
Copy link
Contributor
@helioguardabaxo helioguardabaxo commented Jan 22, 2021 •
edited by mquandalle
Loading

This change is Reviewable

@jrsupplee
Copy link
Contributor

How does the scrolling work on mobiles?

Also what if you want the current behavior of wrapping instead of scrolling? I personally do not like horizontal scrolling. IMO would be better to have something you click on to enable the scrolling behavior.

@helioguardabaxo
Copy link
Contributor Author

@jrsupplee
I have boards with multiples lists. In My Cards this lists and its cards shows outside the boundaries.
Your suggestion is good, but I don't know how to implements.Could you help?

@jrsupplee
Copy link
Contributor
jrsupplee commented Jan 22, 2021 •
edited
Loading

I see the problem now. There was a change made to the list style to use table-cell instead of inline-block (3866ed3).

.my-cards-list-wrapper
  margin: 1rem
  border-radius: 5px
  padding: 1.5rem
  padding-top: 0.75rem
  display: table-cell
  min-width: 250px
  max-width: 350px

I think it should be changed back to inline-block

@jrsupplee
Copy link
Contributor

@jrsupplee
I have boards with multiples lists. In My Cards this lists and its cards shows outside the boundaries.
Your suggestion is good, but I don't know how to implements.Could you help?

Your solution is not a bad one for display: table-cell for lists.

The boards URL is a good idea, but not sure about the window to the right. Is that symbol used elsewhere in Wekan for a link?

@helioguardabaxo
Copy link
Contributor Author
helioguardabaxo commented Jan 22, 2021 •
edited
Loading

I thought that a icon/link could create a destac, but brokes Wekan design harmony.
It's better a text link?

Additionally, I tried to set board color, but doesn't works. I tried this:
.my-cards-board-title(class=board.colorClass)
Any suggestion?

xet7 added a commit that referenced this pull request Jan 22, 2021
@xet7
Revert table-cell back to inline-block at my-cards-list-wrapper.
da12c84 
Thanks to jrsupplee and xet7 !

Fixes #1667,
related #3469
@jrsupplee
Copy link
Contributor

I thought that a icon/link could create a destac, but brokes Wekan design harmony.
It's better a text link?

Additionally, I tried to set board color, but doesn't works. I tried this:
.my-cards-board-title(class=board.colorClass)
Any suggestion?

I think that background colors are being set in myCards.styl. Inspect the webpage and see what styles are being applied.

@helioguardabaxo
Copy link
Contributor Author

I inspected element in two differents boards in My Cards and found:
class="my-cards-board-title board-color-belize"
class="my-cards-board-title board-color-pomegranate"

If I disable background-color in myCards.styl, the element becomes transparent and keeps the class above.

@helioguardabaxo
Copy link
Contributor Author

I found here:
.my-cards-board-title(class=board.colorClass, id="header")

It's works!

@helioguardabaxo
Copy link
Contributor Author

I will close this PR and adjust the title link.

@jrsupplee
Thanks for you help and suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helioguardabaxo @jrsupplee
0