8000 Calendar by TNick · Pull Request #1728 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Calendar #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2018
Merged

Calendar #1728

merged 4 commits into from
Jun 27, 2018

Conversation

TNick
Copy link
Contributor
@TNick TNick commented Jun 26, 2018

Adds a calendar view.

This is work in progress. Please comment and contribute.


This change is Reviewable

TNick added 2 commits June 26, 2018 19:55
A dependency to rzymek:fullcalendar has also been added.
@xet7
Copy link
Member
xet7 commented Jun 26, 2018

@TNick

Does this show card's Received/Start/Due/End dates in calendar?

@xet7
Copy link
Member
xet7 commented Jun 26, 2018

@TNick

I'll try it when I have some free time. Thanks!

@xet7 xet7 mentioned this pull request Jun 26, 2018
@xet7
Copy link
Member
xet7 commented Jun 26, 2018

Calendar issue at #808 . It also has bounties.

@TNick
Copy link
Contributor Author
TNick commented Jun 26, 2018

@xet7 uses start and end to display the card as an interval and shows the title of the card at this point.

A link to the card is inserted but does nothing because the code does not know to switch to another view.

An easy next step is type use the card detail template to show cardDetail in a popup when the user clicks a card.

Then changing default view to our minicard would be nice.

Cards that only have start or end should be presented at that time with a 1 hour duration.

Cards that have no time info should be presented in a separate side list so that the user can drag them into place.

@TNick
Copy link
Contributor Author
TNick commented Jun 26, 2018

Also, it would be possible to show same card more than once:

  • once if there is a received time with a distinct color
  • once the start-end interval
  • finally if there is a due date => short event in another distinctive color.

The alternative is two intervals: start-end and received-due but I would guess it becomes unreadable pretty fast.

TNick added 2 commits June 27, 2018 16:25
staringatlights:flow-router is another incarnation of kadira:flow-router
kadira:flow-router is not an explicit dependency but useraccounts:flow-routing depends on it.
This commit gets rid of an anoying message informing that a route has
not been found.
@xet7 xet7 merged commit 0394a78 into wekan:devel Jun 27, 2018
@d3dbit
Copy link
d3dbit commented Jul 3, 2018

Hello @TNick ,

I have been trying the new calendar and that's great!! Very good job!

But let me say to you:

  1. I see all the cards in the same (blue) color. Could it be possible to show the cards with the colors of the labels (if the cards have some labels)?
  2. I think that it would be interesting to all the wekan community to see the card's details when the users click cards. But you said: "A link to the card is inserted but does nothing because the code does not care detail switch to another view.
    An easy next step is a typical use the card detail template to show card details the card's details user clicks a click
    "
  3. Is it possible to move the calendar button next to filter or search button? I think that it is not useful to need to change between lists view to swimlanes view to calendar view. I think that it would be nice to get a direct access to the the calendar.

Thanks a lot for your work.

@h0jeZvgoxFepBQ2C
Copy link
Contributor
h0jeZvgoxFepBQ2C commented Jul 5, 2018

Is it possible to move the calendar button next to filter or search button? I think that it is not useful to need to change between lists view to swimlanes view to calendar view. I think that it would be nice to get a direct access to the the calendar.

+1

Also I'm not sure if I did something wrong, but the calendar doesn't work for me correctly.
I set end dates for multiple cards (and also start date afterwards), but there is no single card displayed in the calendar view? The calendar is just empty.
I tried it also with a completely new board - same effect - no card shows up in calendar.

@TNick TNick mentioned this pull request Jul 5, 2018
@TNick
Copy link
Contributor Author
TNick commented Jul 5, 2018
  1. Colors: I see two issues here:

    1. the color of the card: this is something we should have in wekan independently of the calendar feature; the calendar implementation should only inherit it;
    2. the labels: the logical approach for this would be some refactoring of the minicard code but - as I said elsewhere - the code is not very well isolated. Of course that simply showing a blue rectangle is underwhelming.
  2. clicking on the card should show card details with current implementation in Calendar #1752

  3. Having a separate button is not a problem if there's a consensus.

  4. Would appreciate some feedback about the way the four (4) distinct dates of a card should be presented in the calendar. TBH I do not use this feature right now in my implementation.

@lichtamberg Right now we use start and end date. Please see #1752; if it still doesn't work please export the board and post it here.

@d3dbit
Copy link
d3dbit commented Jul 5, 2018

@TNick ,

clicking on the card should show card details with current implementation in #1752

Good job!

Having a separate button is not a problem if there's a consensus.

By now you have two OKs :-) (@lichtamberg and me hehe)

Thanks a lot.

@h0jeZvgoxFepBQ2C
Copy link
Contributor

@TNick I tried it with start date and end date, nothing works for me. I've exported my completely new testboard and posted the json here: https://pastebin.com/zkaVzjtU

@h0jeZvgoxFepBQ2C
Copy link
Contributor

About the dates, I would not show timeframes, but only single-day-entries for the corresponding received/start/finished/.. date - it leads to a complete UI mess if you have more than 5 cards running parallel imho.

@TNick
Copy link
8000
Contributor Author
TNick commented Jul 5, 2018

@lichtamberg due field was filled in; please enter a date in end

@TNick
Copy link
Contributor Author
TNick commented Jul 5, 2018

@lichtamberg And how long would each entry be, time wise? 1 hour? 1/2 hour?

@h0jeZvgoxFepBQ2C
Copy link
Contributor

Ahhh sorry... 🤦‍♂️ I did it three times wrong lol - it works now.

I think we have a different workflow for using this calender - we never (or not often) have really end dates, only due dates.. The end dates are not so important for us, so we are not using this field.

Most of the time we also don't have any duration, since we are only setting the due date - not other date field is filled out.

Also (if there is a start date, which is in about 2% of all cards) - the duration of our cards are also never intra-day, but from 2 days to 2 months long - we also don't use the hour selector to define the exact time.

So (beside what other people need :) ) we only need a week/month/year/list view - and because we have so many parallel cards, making the durations visible in the calendar would mess up everything and it won't be usable for us. For us the approch would be better, to just mark the single days in the calendar - not the whole duration. This would make it also easier to distinguish the event types (received date, start date, due date, end date)

Thank you very much for your great work ❤️

@d3dbit
Copy link
d3dbit commented Jul 11, 2018

The calendar feature is fantastic. Great job!


@lichtamberg said:

"I think we have a different workflow for using this calender - we never (or not often) have really end dates, only due dates.. The end dates are not so important for us, so we are not using this field."

Mee too. I did not use "end dates", only "due dates".
For me (and my team) if we have an activity scheduled it should have a "due date", but not an "end date" because the activity is not done. And when the activity is finished, then it will have an "end date".
Perhaps, instead of using the "end dates" to drawing the cards in the calendar, would be better to use the "due dates".
Remind that the "due dates" appears as yellow or red when the activity is nearing due date, but the "end dates" do not have reminders (do not appear as yellow or red), so I think that it could be the other reason to use "due dates" vs. "end dates".
On the other hand, for me, is a good decision to not use "received date" for drawing the cards in the calendar. It is OK to use the "start date".

@lichtamberg said:

"making the durations visible in the calendar would mess up everything and it won't be usable for us. For us the approch would be better, to just mark the single days in the calendar - not the whole duration. This would make it also easier to distinguish the event types (received date, start date, due date, end date)"

Oh no. I do not agree.
I think that it is a good feature to mark the whole duration in the calendar (please, @TNick do not remove this feature).
The Wekan Calendar should be as close as possible to the (for example) Outlook Calendar. When you want to see all the day appointments you can see it sorted from their start time and you can see all the appointments duration. I think that it is good.


Let me repeat: The calendar feature is so great. Thanks for implementing it.

@h0jeZvgoxFepBQ2C
Copy link
Contributor
h0jeZvgoxFepBQ2C commented Jul 11, 2018

Oh no. I do not agree.
I think that it is a good feature to mark the whole duration in the calendar (please, @TNick do not remove this feature).
The Wekan Calendar should be as close as possible to the (for example) Outlook Calendar. When you want to see all the day appointments you can see it sorted from their start time and you can see all the appointments duration. I think that it is good.

Maybe it would be good to have a calendar setting per board, so you can select if you want to have shown the full timeframe or just the single days?

For us it wouldn't work - we have about 50-60 cards parallel running, so having 50-60 lines for each single day would make it impossible to use the calendar.

Maybe there is one more or less easy solution: if start and end/due date is set, show the whole duration - and if only the due/end date is set (and no start/received date), just show a single day entry on the corresponding date?

@d3dbit
Copy link
d3dbit commented Jul 11, 2018

@TNick , in fact, as we can see in this issue #1668 when we apply an "end date" the alarm (color yellow or red) of the "due dates" should disappear.

A good new feature could be:

  1. Changing the "end date" for the "due date" for adding a card in the calendar view
  2. Changing the color on the card in the calendar view depending on the color of the "due date" on the card

@lichtamberg said:

"Maybe it would be good to have a calendar setting per board, so you can select if you want to have shown the full timeframe or just the single days?"

Great!!

@TNick
Copy link
Contributor Author
TNick commented Jul 11, 2018

Hey, everybody. Sorry for being slow with the replies.
It was and are quite busy at work and I don't have much time to implement changes.
That being said the changes are coming and my personal opinion is that we will implement as many combinations as possible and those should be governed by settings.

So if you have any other thoughts about the calendar feature, please add them here.

However, right now my efforts regarding wekan are directed toward converting the entire code base into using modules and imports/exports so that we can also have tests and we can use wekan as a package.

I hope this is something the community can get behind.
@xet7 what do you think?

@TNick
Copy link
Contributor Author
TNick commented Jul 11, 2018

@d3dbit I must say it's not entirely clear to me the distinction between the four values.
IMHO the user should be able to choose - for any particular board - the content of the cards, including which dates are shown and how, checkboxes, subtasks, description, and everything else.

@xet7
Copy link
Member
xet7 commented Jul 11, 2018

@TNick

What kind of package, modules, imports/exports? Please give more details. Thanks!

@TNick
Copy link
Contributor Author
TNick commented Jul 11, 2018

@xet7 please have a look here
Most of the server side code was moved into imports

Edit: the code does not work right now, so don't bother testing it. It's work in progress. It is just meant to show the layout that I have in mind. Once it is running the ReadMes in each directory will be updated.

@d3dbit
Copy link
d3dbit commented Jul 11, 2018

@TNick :

"the user should be able to choose - for any particular board - the content of the cards, including which dates are shown and how, checkboxes, subtasks, description, and everything else."

Great. I agree with you.
Thanks.

"However, right now my efforts regarding wekan are directed toward converting the entire code base into using modules and imports/exports so that we can also have tests and we can use wekan as a package."

Nice job. But, IMHO is more important/urgent/necessary the calendar that the other. I think that the calendar is a necessary feature to compete against other kanban apps.

@TNick
Copy link
Contributor Author
TNick commented Jul 12, 2018

@d3dbit my interest in wekan is a bit more selfish. It is not the eternal glory of the project. 😁
Shoudn't take too long.

@amahoneyLIT
Copy link

Hi guys, this feature looks nice so far. I noticed a problem on my 2560x1440 monitor and using chrome, that if I make the window wide enough, I have to scroll down to see all the weeks in the month (e.g. I can only see 4 out of 6 weeks in the calendar). If I scroll down and click an item in the 5th week, the left panel opens up, but is cut off and I can't scroll up to view it properly

wekan calendar scolling issues

I think a good fix would be to always fit the 6 weeks on the screen without changing to scroll.

@d3dbit
Copy link
d3dbit commented Jul 27, 2018

@TNick I have the same issue as @amahoneyLIT .


On the other hand, what about one of my first request?:

"Is it possible to move the calendar button next to filter or search button? I think that it is not useful to need to change between lists view to swimlanes view to the calendar view. I think that it would be nice to get a direct access to the calendar."


Thanks. Very good job.

@TNick
Copy link
Contributor Author
TNick commented Jul 29, 2018

Sorry, quite busy at work. Will do when there's time if nobody else steps up.

@martin3785
Copy link

I don't know how to get the Cards in the calendar view.
I have intalled a new ubuntu os with wekan. Cards work well but no Cards are shown in the calendar.

@xet7
Copy link
Member
xet7 commented Aug 23, 2018

@martin3785

At card details, add due dates etc other dates. They will then show at calendar, I think. I have not tested it so well yet.

@d3dbit
Copy link
d3dbit commented Aug 24, 2018

@martin3785
You should add a start and a finish date (both) in the cards. Due dates do not add an appointment to the calendar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0