8000 Feature Request: Search in all boards · Issue #2074 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature Request: Search in all boards #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rlach opened this issue Dec 27, 2018 · 42 comments
Closed

Feature Request: Search in all boards #2074

rlach opened this issue Dec 27, 2018 · 42 comments
Milestone

Comments

@rlach
Copy link
rlach commented Dec 27, 2018

Problem description:

  • Wekan can currently search for cards only in the current board. In Trello you can also choose to search in all boards you have access to.

This way you could:

  • find subtasks related to stories you currently have in your board
  • find cards in other boards matching selected name

It's very useful for workflows where users move stories between boards.

Screenshot of the search example on Trello:
zrzut ekranu z 2018-12-27 13-30-08

@superlou
Copy link
superlou commented Jan 4, 2019

It would also be really helpful if this could search for all cards that someone is a member of. This could satisfy some use cases of #2055.

@xet7 xet7 added this to the 2020-05-31 Search milestone Jan 11, 2019
@bhueck
Copy link
bhueck commented Feb 4, 2019

I also think this is a "must have" feature to get wekan in production (for a company).

@gsommavilla
Copy link

Is there any update about this issue?
The "search-in-all-boards" feature is really something that I would love to have.

@xet7
Copy link
Member
xet7 commented Jul 2, 2019

@gsommavilla

No one has started coding search all boards feature yet. It would require someone to have time to read Wekan source code existing search feature, and add to it searching for other boards of user too. Code contributions as pull requests welcome. See Wekan GitHub wiki for Developer Docs and Directory Structure.

@xet7
Copy link
Member
xet7 commented Jul 2, 2019

If it is really important to have this soon, someone can pay 500 euro for my time to develop this feature:
https://wekan.team/commercial-support/

@r0bbie
Copy link
r0bbie commented Jul 3, 2020

While I can't support the 500 € at this point unfortunately, would definitely be really keen to see this feature at some point, and if there was a BountySource (or similar, since I see you're moving away from that!) setup I'd happily chip in with others.

@xet7
Copy link
Member
xet7 commented Jul 3, 2020

@r0bbie

Current payment methods are here:
https://wekan.team/commercial-support/

It works similarly, so if someone sends some part of that 500 € then it is added to Roadmap.

@xet7
Copy link
Member
xet7 commented Sep 15, 2020

Moved to here from #552 (comment)

From @gregruthenbeck

Search doesn't search comments. It would be great if it did.

Yes, I would think this Search in all boards will include searching comments. I did get funding for this feature at this week.

Can this behavior be added/enabled relatively easily?

No, it can not be added relatively easily. Programming this requires many hours of work to get feature working correctly. Anyway, I hope to get this finished at this year.

@xet7
Copy link
Member
xet7 commented Sep 16, 2020

Someone asked at Wekan Community:

Does anybody knows whether you can filter card by comment date, to get the cards that have been commented in the last week for instance ?

Maybe this could be related to this search instead, being some search option.

@superlou
Copy link

@xet7 Is this still estimated to be 500 euro of development?

@xet7
Copy link
Member
xet7 commented Nov 19, 2020

@superlou

In theory, yes, and that 500 euro has already been prepaid. In practice, it could be just enough, or require total 1000 euro of work. It could work fine, or slow down Wekan a lot.

Usually it's just throwing a lot of features to Wekan to see could it even possibly work.

@superlou
Copy link

Ah, that makes sense. I'm going to look into getting further sponsors.

< 8000 input type="hidden" data-csrf="true" name="authenticity_token" value="4dzu6VQbA5oPLawhaWpFXOt9dg/Yxe9Y/vjaONFOpFv+8JMjpQ5LdQ+60qSA2fIDYoPMrHA1z+kDX9qcAOXIpQ==" />

xet7 added a commit that referenced this issue Jan 16, 2021
@jrsupplee
Copy link
Contributor

Search all boards functionality has been added, including the following functionality:

  • Refine search with operators (list title, board title, swimlane, ...)
  • Fuzzy search on text
  • Allow searching via URL

I have yet to implement:

  • operators for searching on archived/open cards
  • allow for negating operator specifications

After implementing the above search will have all the functionality that I intended.

Of course, comments and feedback are welcome.

@xet7
Copy link
Member
xet7 commented Jan 18, 2021

Those new changes will be in next Wekan release, that will happen sometime today or tomorrow. I will fix one not-related Wekan bug before making new Wekan release.

@jrsupplee
Copy link
Contributor

@xet7

Not sure if you looked at the way I did the translatable search instructions using Markdown. Do you think this will be a problem for translators?

@xet7
Copy link
Member
xet7 commented Jan 18, 2021

@jrsupplee

No. First that I have tested and figured out Finnish translations, I will add info for translators to Transifex about how to translate.

@xet7
Copy link
Member
xet7 commented Jan 18, 2021

@jrsupplee

Can you make colors translated, with examples? For example, now when in English I search:

label:red

In Finnish I can currently search:

nimilappu:red

Colors are already translated like color-red, so with that added, I could search for:

nimilappu:punainen

At search instructions could be a list of labels with translated color names, where for example red labels have red background and same visible-enough (light or dard) foreground color like at labels at board:

[red] [yellow]...

That would be in Finnish:

[punainen] [keltainen]...

@jrsupplee
Copy link
Contributor

@xet7
I will look at this. I don't think it will be difficult.

@xet7 xet7 closed this as completed Jan 19, 2021
@jrsupplee
Copy link
Contributor

@xet7
Sorry to comment on a closed issue, but did not want to open a new one.

I have been thinking about your suggestion of having a list of the color like the label. I worked something up and added functionality so that clicking on the color adds it to the search.

image

I did the same thing for list names.

We could do something like this for all the different criteria but if the lists get big it will become unwieldy.

What do you think, is this worth pursuing?

Cod 8000 e: https://github.com/jrsupplee/wekan/tree/new-search

@xet7
Copy link
Member
xet7 commented Jan 20, 2021

@jrsupplee

Yes, this is great! I also do not remember color names etc, and what they are when translated to Finnish, so it's great to have visible list of all those search options. Please add PR. Thanks a lot!

@xet7
Copy link
Member
xet7 commented Jan 22, 2021

@jrsupplee

Is it already possible to search from attachment filenames? If not, is it possible for you to add that?

@xet7
Copy link
Member
xet7 commented Jan 22, 2021

@jrsupplee

What do you think, would it be possible for you to add feature My Attachments ? That would show all attachments of your member boards and public boards?

@xet7
Copy link
Member
xet7 commented Jan 22, 2021

@jrsupplee

Also, if you don't have time, please ignore my questions above.

@jrsupplee
Copy link
Contributor

@xet7

Is it already possible to search from attachment filenames? If not, is it possible for you to add that?

I have added some new operators (due date, created date, modified date). I don't think this would be difficult but I have not looked at attachments.

@jrsupplee
Copy link
Contributor

@xet7

What do you think, would it be possible for you to add feature My Attachments ? That would show all attachments of your member boards and public boards?

Might be best to add this as a feature request. I don't have time to do this now, but I doubt it would be difficult.

The time consuming part for me is the HTML (jade) and CSS to display things in a decent way. My Cards should be modified to look more like the Wekan theme. But it works so I am not motivated to spend the time tweaking the display.

@xet7
Copy link
Member
xet7 commented Jan 22, 2021

@jrsupplee

Ok, I'll add it as Feature Request, so someone interested in it can add it.

@mfilser
Copy link
Contributor
mfilser commented Jan 22, 2021

I am not sure to open a new issue or not.
At global search: If using Wekan with German language, the sort does not work with lists / boards / labels.
For example here is a screenshot:
grafik

grafik

grafik

grafik

@jrsupplee
Copy link
Contributor
jrsupplee commented Jan 22, 2021

@mfilser

I am not sure to open a new issue or not.
At global search: If using Wekan with German language, the sort does not work with lists / boards / labels.

The problem is with the German translation of the operators. They should be specified in lowercase but in German they have the first letter capitalized. I will submit a patch to account for this.

Until then you can search with the abbreviated operators.

  • b:"Test" for board
  • s for swimlane
  • l for list
  • m for member
  • a for assignee

@mfilser
Copy link
Contributor
mfilser commented Jan 22, 2021

@jrsupplee
Thank you a lot, i will try it.

I just clicked on the label, list and board tags you created, maybe the abbreviated letters can be the default behavior for this?

Also thank you a lot for your work, you are doing very well.
Also @xet7 of course.
And all others of course too ;)

@xet7
Copy link
Member
xet7 commented Jan 22, 2021

Fix for search operators with uppercase letters at #3470

@bronger
Copy link
Contributor
bronger commented Jan 24, 2021

I still see an issue: The direct link generated to the global search contains i18n operators but this is not accepted by Wekan. In the URL, only English operator names are accepted.

@xet7 xet7 reopened this Jan 24, 2021
@jrsupplee
Copy link
Contributor

@xet7

I had trouble getting TAPi18n.__() to work in a template onCreated. It always seemed to return the English (the default). What is going on with this?

@jrsupplee
Copy link
Contributor

It looks like .onCreated() is called before insertion to the DOM. So I guess I should use .onRendered()

@bronger
Copy link
Contributor
bronger commented Feb 1, 2021

I18n operator names in query strings in URLs still do not work in v4.91.

@jrsupplee
Copy link
Contributor

@bronger

Could you try opening the inspection console for the page and then running the searches again.

@bronger
Copy link
Contributor
bronger commented Feb 1, 2021

I don’t understand what you need me to do. You can see the problem here: https://op.its.kfa-juelich.de:8843/global-search?q=Liste%3AA. Login/password is test/12345.

@jrsupplee
Copy link
Contributor

I can ping the server op.its.kfa-juelich.de but Wekan will not open.

@bronger
Copy link
Contributor
bronger commented Feb 1, 2021

Sorry, drop the port number. Login as test/12345 at https://op.its.kfa-juelich.de/, then open https://op.its.kfa-juelich.de/global-search?q=Liste%3AA.

@jrsupplee
Copy link
Contributor
jrsupplee commented Feb 1, 2021

@xet7

There is an issue that the TAPi18n language does not get set before the onRendered() of the component is called.

Is it possible that this code from i18n.js could have a slight delay in its execution so it completes after onRendered() is called?

// We save the user language preference in the user profile, and use that to set
// the language reactively. If the user is not connected we use the language
// information provided by the browser, and default to english.

Meteor.startup(() => {
  TAPi18n.conf.i18n_files_route = Meteor._relativeToSiteRootUrl('/tap-i18n');
  Tracker.autorun(() => {
    const currentUser = Meteor.user();
    let language;
    if (currentUser) {
      language = currentUser.profile && currentUser.profile.language;
    }

    if (!language) {
      if (navigator.languages) {
        language = navigator.languages[0];
      } else {
        language = navigator.language || navigator.userLanguage;
      }
    }

    if (language) {
      TAPi18n.setLanguage(language);
      // eslint-disable-next-line no-console
      console.log('language set!');
      T9n.setLanguage(language);
    }
  });
});

@xet7
Copy link
Member
xet7 commented Feb 1, 2021

@jrsupplee

Yes, tap:i18n is old and buggy. I also have problem that at serverside with Meteor.isServer it does not translate to user's language.

Is it possible for you to try changing tap:i18n to ostrio:i18n https://atmospherejs.com/ostrio/i18n if it's any better? For example:

cd wekan

meteor remove tap:i18n

meteor add ostrio:i18n

And then trying does translation syntax mentioned at https://atmospherejs.com/ostrio/i18n work?

Alternatively, there could be other i18n packages that could maybe work: https://atmospherejs.com/?q=i18n

@jrsupplee
Copy link
Contributor

@xet7

@jrsupplee

Yes, tap:i18n is old and buggy. I also have problem that at serverside with Meteor.isServer it does not translate to user's language.

Is it possible for you to try changing tap:i18n to ostrio:i18n https://atmospherejs.com/ostrio/i18n if it's any better?

Sounds like a lot of work and the documentation for ostrio:i18n is pretty sparse.

I tried removing the TAPi18n initialization code from the Tracker.autorun(). This is possibly delaying the execution. The system seems to run fine. So i18n.js is now:

Meteor.startup(() => {
  TAPi18n.conf.i18n_files_route = Meteor._relativeToSiteRootUrl('/tap-i18n');
  const currentUser = Meteor.user();
  let language;
  if (currentUser) {
    language = currentUser.profile && currentUser.profile.language;
  }

  if (!language) {
    if (navigator.languages) {
      language = navigator.languages[0];
    } else {
      language = navigator.language || navigator.userLanguage;
    }
  }

  if (language) {
    TAPi18n.setLanguage(language);
    // eslint-disable-next-line no-console
    console.log('language set!');
    T9n.setLanguage(language);
  }
});

What do you think, could this solve the issue?

@xet7
Copy link
Member
xet7 commented Feb 2, 2021

@jrsupplee

Please add pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants
0