feat(typescript): convert to typescript #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't want to convert to typescript |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to typescript.
The test script has been run and passed. Also I put this generated js file in the webpack repo, replace the
Tapablein thenode_modules, and the test results are same as before.Here're the questions need to be discussed:
jsfile is pointing tolibfolder, which means it will be overwritten everytime we run thenpm run devcommand. Do we need to change it to another directory (but we have to updatepackage.jsonas well)?typingsfolder and I haven't include that in the PR. Do I need to include it?For the sake of keeping this compatiable with current API, the code hasn't change to much other than using arrow functions and adding typing informations. But as I mentioned in issue #15 , we can create documentations automatically after this.