refactor: consolidate HMR code #19629
Merged
+57
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #19629 will degrade performances by 72.06%Comparing Summary
Benchmarks breakdown
|
|
@hai-x Weird codecov report... |
alexander-akait
approved these changes
Jun 26, 2025
| Template.getFunctionContent( | ||
| require("../hmr/JavascriptHotModuleReplacement.runtime.js") | ||
| ) | ||
| .replace(/\$key\$/g, "jsonp") |
There was a problem hiding this comment.
Before we have jsonp, now module, is it expected change?
There was a problem hiding this comment.
But it is just $key, so I think it is fine to change
/cc @xiaoxiaojx
| @@ -407,7 +389,7 @@ class ModuleChunkLoadingRuntimeModule extends RuntimeModule { | |||
| `var loadScript = ${runtimeTemplate.basicFunction( | |||
| "url, onResolve, onReject", | |||
| [ | |||
| `return ${importFunctionName}(/* webpackIgnore: true */ url).then(onResolve).catch(onReject)` | |||
There was a problem hiding this comment.
Why remove? If we try to bundle already bundled webpack without it will output an error/warning
There was a problem hiding this comment.
Good catch. Thank you. I will revert it.
|
@hai-x let's rebase and we can merge |
alexander-akait
approved these changes
Jun 26, 2025
sins921
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Extract duplicate HMR logic into
helpermodule.We currently rely on the
fetchAPI to get the HMR manifest, limiting support to browser environments, so Improve the error message for better understanding.Did you add tests for your changes?
Existing
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing