8000 fix(test): update tests for ESM HMR by xiaoxiaojx · Pull Request #19624 · webpack/webpack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(test): update tests for ESM HMR #19624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix(test): update tests for ESM HMR #19624

merged 1 commit into from
Jun 24, 2025

Conversation

xiaoxiaojx
Copy link
Member
@xiaoxiaojx xiaoxiaojx commented Jun 24, 2025 •
edited
Loading

What kind of change does this PR introduce?
Fixes: update test cases where tests ended before hot-update.js files were generated.

Did you add tests for your changes?

Yes
Does this PR introduce a breaking change?

No
What needs to be documented once your changes are merged?
No

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19624 will degrade performances by 21.39%

Comparing feat/esm-hmr-test (74bad88) with main (c109f97)

Summary

❌ 2 regressions
✅ 119 untouched benchmarks
⁉️ 12 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 52.1 ms 61.6 ms -15.32%
⁉️ benchmark "lodash", scenario '{"name":"mode-development","mode":"development"}' 735.6 ms N/A N/A
⁉️ benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 34.7 ms N/A N/A
⁉️ benchmark "lodash", scenario '{"name":"mode-production","mode":"production"}' 9.8 s N/A N/A
⁉️ benchmark "many-chunks-commonjs", scenario '{"name":"mode-development","mode":"development"}' 247.2 ms N/A N/A
⁉️ benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 61.3 ms N/A N/A
⁉️ benchmark "many-chunks-commonjs", scenario '{"name":"mode-production","mode":"production"}' 2 s N/A N/A
⁉️ benchmark "many-chunks-esm", scenario '{"name":"mode-development","mode":"development"}' 243.6 ms N/A N/A
⁉️ benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 61.5 ms N/A N/A
⁉️ benchmark "many-chunks-esm", scenario '{"name":"mode-production","mode":"production"}' 2.3 s N/A N/A
⁉️ benchmark "many-modules-commonjs", scenario '{"name":"mode-development","mode":"development"}' 308.9 ms N/A N/A
⁉️ benchmark "many-modules-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 52.5 ms N/A N/A
⁉️ benchmark "many-modules-commonjs", scenario '{"name":"mode-production","mode":"production"}' 2.1 s N/A N/A
❌ benchmark "minimal", scenario '{"name":"mode-development","mode":"development"}' 24.1 ms 30.7 ms -21.39%

@alexander-akait alexander-akait merged commit 21b28a8 into main Jun 24, 2025
42 of 44 checks passed
@alexander-akait alexander-akait deleted the feat/esm-hmr-test branch June 24, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoxiaojx @alexander-akait
0