8000 HMR support for ESM by xiaoxiaojx · Pull Request #19616 · webpack/webpack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

HMR support for ESM #19616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

HMR support for ESM #19616

merged 2 commits into from
Jun 23, 2025

Conversation

xiaoxiaojx
Copy link
Member
@xiaoxiaojx xiaoxiaojx commented Jun 20, 2025 •
edited
Loading

What kind of change does this PR introduce?

feature: HMR support for ESM. Original PR #19561

Did you add tests for your changes?

Yes
Does this PR introduce a breaking change?

No
What needs to be documented once your changes are merged?

Yes

@xiaoxiaojx xiaoxiaojx mentioned this pull request Jun 20, 2025
Closed
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19616 will degrade performances by 69.28%

Comparing feat/esm-hmr-chunk-generation (f64aabb) with main (a55ac0e)

Summary

⚡ 3 improvements
❌ 79 regressions
✅ 51 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 42.4 ms 10.3 ms ×4.1
⚡ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 49.2 ms 42.4 ms +16.19%
❌ benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 10.5 ms 34.2 ms -69.28%
⚡ benchmark "minimal", scenario '{"name":"mode-development","mode":"development"}' 30.6 ms 24.1 ms +27.09%
❌ md4 buffer benchmark (size: 10000) 72.7 µs 114 µs -36.26%
❌ md4 buffer benchmark (size: 120) 34.5 µs 76.1 µs -54.6%
❌ md4 buffer benchmark (size: 160) 34.6 µs 76.1 µs -54.56%
❌ md4 buffer benchmark (size: 16366) 97.1 µs 138.5 µs -29.93%
❌ md4 buffer benchmark (size: 16368) 97.1 µs 138.5 µs -29.91%
❌ md4 buffer benchmark (size: 16370) 97 µs 138.6 µs -29.99%
❌ md4 buffer benchmark (size: 2) 34.4 µs 76.3 µs -54.86%
❌ md4 buffer benchmark (size: 20) 32.2 µs 76.3 µs -57.81%
❌ md4 buffer benchmark (size: 200) 34.9 µs 76.2 µs -54.27%
❌ md4 buffer benchmark (size: 2000) 40.4 µs 81.8 µs -50.67%
❌ md4 buffer benchmark (size: 20000) 111.2 µs 152.6 µs -27.12%
❌ md4 buffer benchmark (size: 2002) 40.4 µs 81.9 µs -50.72%
❌ md4 buffer benchmark (size: 40) 32.1 µs 73.5 µs -56.31%
❌ md4 buffer benchmark (size: 400) 35.5 µs 77.1 µs -53.89%
❌ md4 buffer benchmark (size: 40000) 187.5 µs 228.9 µs -18.09%
❌ md4 buffer benchmark (size: 65536) 285.8 µs 327.3 µs -12.67%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@xiaoxiaojx xiaoxiaojx force-pushed the feat/esm-hmr-chunk-generation branch 2 times, most recently from 8b4c52b to 422d7f4 Compare June 21, 2025 11:56
@xiaoxiaojx xiaoxiaojx changed the title [WIP] HMR support for ESM HMR support for ESM Jun 21, 2025
@xiaoxiaojx xiaoxiaojx force-pushed the feat/esm-hmr-chunk-generation branch from 422d7f4 to 5e68bc4 Compare June 21, 2025 14:25
< 8000 /div>
@xiaoxiaojx xiaoxiaojx force-pushed the feat/esm-hmr-chunk-generation branch from 5e68bc4 to f64aabb Compare June 21, 2025 15:13
@3ru
Copy link
Contributor
3ru commented Jun 21, 2025 •
edited
Loading

Hi @xiaoxiaojx, thank you for taking over. Is there a way to contact you directly? I'd like to discuss something with you. Thanks and the implementation looks solid overall!

@xiaoxiaojx
Copy link
Member Author
xiaoxiaojx commented Jun 22, 2025 •
edited
Loading

Hello @3ru , You can reach me on Telegram (natsu_xiao) or WeChat (natsu_xiao) . I’d be happy to chat about webpack anytime.

@alexander-akait alexander-akait merged commit 09fda87 into main Jun 23, 2025
43 of 44 checks passed
@alexander-akait alexander-akait deleted the feat/esm-hmr-chunk-generation branch June 23, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxiaojx @3ru @alexander-akait
0