8000 fix: Unexpected Error Codes from fs.unlink on Windows by xiaoxiaojx · Pull Request #19586 · webpack/webpack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Unexpected Error Codes from fs.unlink on Windows #19586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

fix: Unexpected Error Codes from fs.unlink on Windows #19586

merged 1 commit into from
Jun 26, 2025

Conversation

xiaoxiaojx
Copy link
Member

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19586 will degrade performances by 41.49%

Comparing fix/windows_20_unlink (628b1ba) with main (19ca741)

Summary

⚡ 82 improvements
❌ 3 regressions
✅ 36 untouched benchmarks
🆕 12 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 37.5 ms 64.2 ms -41.49%
⚡ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 52.3 ms 9.9 ms ×5.3
🆕 benchmark "lodash", scenario '{"name":"mode-development","mode":"development"}' N/A 722.9 ms N/A
🆕 benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' N/A 34.7 ms N/A
🆕 benchmark "lodash", scenario '{"name":"mode-production","mode":"production"}' N/A 9.8 s N/A
🆕 benchmark "many-chunks-commonjs", scenario '{"name":"mode-development","mode":"development"}' N/A 247.4 ms N/A
🆕 benchmark "many-chunks-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' N/A 62.1 ms N/A
🆕 benchmark "many-chunks-commonjs", scenario '{"name":"mode-production","mode":"production"}' N/A 2 s N/A
🆕 benchmark "many-chunks-esm", scenario '{"name":"mode-development","mode":"development"}' N/A 242.4 ms N/A
🆕 benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' N/A 61.5 ms N/A
🆕 benchmark "many-chunks-esm", scenario '{"name":"mode-production","mode":"production"}' N/A 2.3 s N/A
🆕 benchmark "many-modules-commonjs", scenario '{"name":"mode-development","mode":"development"}' N/A 309.1 ms N/A
🆕 benchmark "many-modules-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' N/A 52.6 ms N/A
🆕 benchmark "many-modules-commonjs", scenario '{"name":"mode-production","mode":"production"}' N/A 2.1 s N/A
⚡ benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.2 ms 9.8 ms +14.55%
❌ benchmark "minimal", scenario '{"name":"mode-development","mode":"development"}' 23.8 ms 30.6 ms -22.09%
❌ benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 31.3 ms 35.7 ms -12.42%
⚡ benchmark "three-long", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 225.1 ms 10.3 ms ×22
⚡ md4 buffer benchmark (size: 10000) 114.1 µs 73.3 µs +55.72%
⚡ md4 buffer benchmark (size: 100000) 447.6 µs 406.9 µs +10.02%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@xiaoxiaojx xiaoxiaojx force-pushed the fix/windows_20_unlink branch 8 times, most recently from 4de1ae2 to b7feb8c Compare June 6, 2025 14:20
@xiaoxiaojx xiaoxiaojx force-pushed the fix/windows_20_unlink branch 2 times, most recently from e7eda8b to 628b1ba Compare June 6, 2025 15:39
@xiaoxiaojx xiaoxiaojx changed the title [WIP] fix: Unexpected Error Codes from fs.unlink on Windows fix: Unexpected Error Codes from fs.unlink on Windows Jun 6, 2025
@alexander-akait alexander-akait merged commit 22c0d02 into main Jun 26, 2025
67 of 83 checks passed
@alexander-akait alexander-akait deleted the fix/windows_20_unlink branch June 26, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@evenstensberg evenstensberg evenstensberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxiaojx @alexander-akait @evenstensberg
0