Create home directory in filemin if not exist #1153
Conversation
|
Actually you can get this same behavior already by adding the line |
Should this setting |
|
Probably not, as it applies any time the user logs into Webmin, and so could create home dirs in cases where the admin doesn't really want it. |
|
Agree with Jamie, create_homedir=1 shall not be default. From my current knowledge filemin is the only module, which requires a homedir. Is it preferred to share code with create_homedir ? |
|
This feels problematic. It seems like Filemin shouldn't require a home directory. It assumes a Webmin user has a matching system user, which isn't always true. So the problem is that Filemin makes assumptions that it shouldn't, and the solution probably isn't for it to try to re-shape the world to fit its wrong assumptions. |
|
I guess, most service accounts and some user accounts, shouldn't have a home directory created for them, by default. |
|
I'd guess it's maybe using home to store configuration, but Webmin has user configuration storage already (in various locations in |
|
I assume the problem is that filemin is configured to limit the user to their home directory, but this doesn't work if there is no home dir? |
|
filemin stores the configuration in users home directory, regardless of the configured directory limits for the user. The configuration in this case is which columns to display and how. So, we would have two options:
|
6ec1f01 to
75f0ca4
Compare
Filemin stores the user configuration in the home directory of the user itself. But it creates the config directory after switching to the desired user account.
If PAM is configured with makehomedir plugin, home directories may not exist until the user first login and cannot be created by the switched Webmin user.
On use of filemin as replacement for interactive login, this is not possible before creating home directory by root or PAM module with suid rights.. When using Webmin on multiple servers in a LDAP domain, this cannot be handled.
This patch creates the home directory of the user to switch to before switching to the user in case not existing and apply access right defaults for home directories.
Afterwards handling of filemin config files can process as before.