8000 Reduce pcap timeout to avoid overflow by bboreham · Pull Request #3782 · weaveworks/weave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Reduce pcap timeout to avoid overflow #3782

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Reduce pcap timeout to avoid overflow #3782

merged 1 commit into from
Mar 11, 2020

Conversation

bboreham
Copy link
Contributor

Fixes #3774

The value is passed by google/gopacket into a signed 32-bit int, so we must pick a timeout which is less than 2^31 microseconds.

See google/gopacket#708

@bboreham bboreham changed the base branch from master to 2.6 March 11, 2020 12:18
@bboreham
Reduce pcap timeout to avoid overflow
0ca831f 
The value is passed by google/gopacket into a signed 32-bit int, so we
must pick a timeout which is less than 2^31 microseconds.

See google/gopacket#708
@bboreham bboreham added this to the 2.6.2 milestone Mar 11, 2020
@murali-reddy
Copy link
Contributor

LGTM

@bboreham bboreham merged commit 15ad210 into 2.6 Mar 11, 2020
@bboreham bboreham deleted the fix-pcap-timeout branch March 11, 2020 16:32
@hairyhenderson hairyhenderson mentioned this pull request Mar 18, 2020
Closed
@bboreham bboreham mentioned this pull request Mar 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.2
Development

Successfully merging this pull request may close these issues.

weaver uses 100% cpu in one thread
2 participants
@bboreham @murali-reddy
10C7
0