8000 Remove trailing zeros in large numbers in UI by sarataha · Pull Request #3760 · weaveworks/scope · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove trailing zeros in large numbers in UI #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2020
Merged

Remove trailing zeros in large numbers in UI #3760

merged 3 commits into from
Mar 14, 2020

Conversation

sarataha
Copy link
Member

Added ~ option to d3Format which trims trailing zeros across format types.

Fixes #3741

@sarataha sarataha changed the title remove trailing zeros in large numbers in UI Remove trailing zeros in large numbers in UI Mar 13, 2020
bboreham
bboreham approved these changes Mar 13, 2020
View reviewed changes
Copy link
Collaborator
@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @sarataha - beautifully simple, and you've added tests too!

I've pushed the branch to the weaveworks repo so integration tests will run.

@bboreham bboreham merged commit f8b8a50 into weaveworks:master Mar 14, 2020
@sarataha sarataha deleted the issues/3741-open-files-format branch March 22, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

@fbarl fbarl Awaiting requested review from fbarl

@qiell qiell Awaiting requested review from qiell

@satyamz satyamz Awaiting requested review from satyamz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad formatting of open files number > 1000
2 participants
@sarataha @bboreham
0