Fix accidental rename of DNS to 'nodes' #3713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 951629a the `DNS` field was accidentally renamed in serialised data to `nodes`. Put it back, and also add a field to fix up data coming from a probe with that fault.
fbarl
reviewed
Oct 17, 2019
report/report.go
Outdated
| @@ -188,7 +188,9 @@ type Report struct { | |||
| // Job represent all Kubernetes Job on hosts running probes. | |||
| Job Topology | |||
|
|
|||
| DNS DNSRecords `json:"nodes,omitempty" deepequal:"nil==empty"` | |||
| DNS DNSRecords `json:"DNS,omitempty" deepequal:"nil==empty"` | |||
| // For release 1.11.6, probes accidentally sent DNS records labeled "nodes". | |||
There was a problem hiding this comment.
Could you please link 951629a in the comment? Just so that it's easier to track how much time has passed.
Related to that, how long do you think we should keep BugDNS field around? Hopefully not forever :O
There was a problem hiding this comment.
Not forever, but If 1.11.6 is the last version that supports pre-1.9 Kubernetes we probably need to keep compatibility for a year or two.
fbarl
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 951629a (part of #3677) the
DNSfield was accidentally renamed in serialised data tonodes. Put it back, and also add a field to fix up data coming from a probe with that fault.🤦♂