8000 scripts: replace JSON.stringify with json-stable-stringify by oleggator · Pull Request #3701 · weaveworks/scope · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

scripts: replace JSON.stringify with json-stable-stringify #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

scripts: replace JSON.stringify with json-stable-stringify #3701

merged 1 commit into from
Oct 7, 2019

Conversation

oleggator
Copy link
Contributor
@oleggator oleggator commented Oct 5, 2019 •
edited by fbarl
Loading

resolves #3133

fbarl
fbarl approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor
@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @oleggator, LGTM! 💯

@fbarl fbarl merged commit f09f9af into weaveworks:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

@bboreham bboreham Awaiting requested review from bboreham bboreham is a code owner

@qiell qiell Awaiting requested review from qiell

@satyamz satyamz Awaiting requested review from satyamz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider replacing JSON.stringify with json-stable-stringify
2 participants
@oleggator @fbarl
0