8000 refactor: remove old unnecessary controls code by bboreham · Pull Request #3680 · weaveworks/scope · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove old unnecessary controls code #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

refactor: remove old unnecessary controls code #3680

merged 1 commit into from
Sep 19, 2019

Conversation

bboreham
Copy link
Collaborator

Scope stopped using NodeControls in bd43c34, and since 1cfc8f4 WireMetrics is identical to Metrics so unnecessary.

@bboreham
refactor: remove old unnecessary controls code
b9b7d03 
Scope stopped using NodeControls in bd43c34, and since
1cfc8f4 WireMetrics is identical to Metrics so unnecessary.
@bboreham bboreham requested a review from qiell as a code owner September 15, 2019 16:41
@qiell qiell requested a review from fbarl September 16, 2019 07:55
fbarl
fbarl approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor
@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👍

qiell
qiell approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor
@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bboreham bboreham merged commit f675c87 into master Sep 19, 2019
@bboreham bboreham deleted the remove-old-control-code branch September 19, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

@qiell qiell qiell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bboreham @fbarl @qiell
0