8000 Fixes "45undefined" in node memory overlay by foot · Pull Request #3673 · weaveworks/scope · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixes "45undefined" in node memory overlay #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2019
Merged

Fixes "45undefined" in node memory overlay #3673

merged 1 commit into from
Sep 13, 2019

Conversation

foot
Copy link
Contributor
@foot foot commented Sep 13, 2019
  • Should be "45MB"
  • Seems like the filesize lib subtley changed their API

Fixes #3672

@foot
Fixes "45undefined" in node memory overlay
a18827f 
- Seems like the filesize lib subtley changed their API
@foot foot requested a review from qiell as a code owner September 13, 2019 14:39
@foot foot requested a review from bboreham September 13, 2019 14:40
@foot
Copy link
Contributor Author
foot commented Sep 13, 2019

Introduced in #3664

@foot
Copy link
Contributor Author
foot commented Sep 13, 2019

avoidwork/filesize.js@3.5.11...4.1.2

avoidwork/filesize.js@a0b268f removed suffixes

bboreham
bboreham approved these changes Sep 13, 2019
View reviewed changes
Copy link
Collaborator
@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham bboreham merged commit ce73474 into master Sep 13, 2019
@bboreham bboreham deleted the 3672-node-memory-overlay-shows branch September 13, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

@qiell qiell Awaiting requested review from qiell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node Memory Overlay shows "undefined" rather than "mb"
2 participants
@foot @bboreham
0