perf(probe): reduce copying of nodes #3679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where we know we are merging several reports into the one, we can call UnsafeMerge() a 8000 nd skip the copy that Merge() will do.
fbarl
approved these changes
Sep 16, 2019
| @@ -210,11 +210,12 @@ func (p *Probe) tag(r report.Report) report.Report { | |||
|
|
|||
| func (p *Probe) drainAndPublish(rpt report.Report, rs chan report.Report) { | |||
| p.rateLimiter.Wait(context.Background()) | |||
| rpt = rpt.Copy() | |||
There was a problem hiding this comment.
Nit: Does the rpt report.Report in the function arg only do a shallow copy? If it's a deep copy, then we don't need this line, if it's shallow, then why not only pass the reference there rpt *report.Report?
There was a problem hiding this comment.
Since Report holds some slices and maps, copying it is shallow so we need the deep copy.
However in Go it is idiomatic to pass a reference only where you intend to modify the data, or when profiling shows the reference to be way more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where we know we are merging several reports into the one, we can call
UnsafeMerge()and skip the copy thatMerge()will do.Small impact; most of the effort goes into collecting the data not publishing it.