8000 fix: handle errors reported by the conntrack package by bboreham · Pull Request #3648 · weaveworks/scope · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: handle errors reported by the conntrack package #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2019
Merged

fix: handle errors reported by the conntrack package #3648

merged 1 commit into from
Jul 4, 2019

Conversation

bboreham
Copy link
Collaborator
@bboreham bboreham commented Jul 4, 2019

In particular, ENOBUFS which indicates data has been dropped.
With this change the collector will restart, thus resynchronising with the OS.

I believe this is the cause of #3645

@bboreham
fix: handle errors reported by the conntrack package
1e6a6a7 
In particular, ENOBUFS which indicates data has been dropped.
With this change the collector will restart, thus resynchronising with
the OS.
@bboreham bboreham requested a review from qiell as a code owner July 4, 2019 13:33
squaremo
squaremo approved these changes Jul 4, 2019
View reviewed changes
Copy link
@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the error .. seems reasonable.

@bboreham bboreham merged commit 8a414d7 into master Jul 4, 2019
@bboreham bboreham deleted the handle-conntrack-error branch July 4, 2019 13:51
@bboreham bboreham mentioned this pull request Jul 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlespiau dlespiau dlespiau approved these changes

@squaremo squaremo squaremo approved these changes

@qiell qiell qiell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bboreham @dlespiau @squaremo @qiell
0