8000 fix: remove unused metric SpyDuration by bboreham · Pull Request #3646 · weaveworks/scope · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: remove unused metric SpyDuration #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2019
Merged

fix: remove unused metric SpyDuration #3646

merged 1 commit into from
Jul 4, 2019

Conversation

bboreham
Copy link
Collaborator
@bboreham bboreham commented Jul 1, 2019

The call to register this metric was removed in #633 over three years ago.
If it isn't registered then nobody can see the values.
The measurement is duplicated by metrics added in #658.

@bboreham bboreham requested a review from qiell as a code owner July 1, 2019 17:00
qiell
qiell approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor
@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qiell qiell self-requested a review July 2, 2019 17:52
qiell
qiell reviewed Jul 2, 2019
View reviewed changes
Copy link
Contributor
@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the import paths which are not in use to fix the failing builds.

@bboreham
fix: remove unused metric SpyDuration
c1e110a 
The call to register this metric was removed in #633 over three years ago.
If it isn't registered then nobody can see the values.
The measurement is duplicated by metrics added in #658.
@bboreham bboreham force-pushed the remove-useless-metric branch from 65eeee5 to c1e110a Compare July 4, 2019 13:53
@bboreham bboreham merged commit 1610148 into master Jul 4, 2019
@bboreham bboreham deleted the remove-useless-metric branch July 4, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiell qiell qiell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboreham @qiell
0