8000 Update contact.ts by su-chang · Pull Request #1861 · wechaty/wechaty · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update contact.ts #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2019
Merged

Update contact.ts #1861

merged 1 commit into from
Sep 30, 2019

Conversation

su-chang
Copy link
Member

there need a newAlias for %s

I'm submitting a...

[x] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

@su-chang
Update contact.ts
c2fb0f8 
there need a `newAlias` for `%s`
huan
huan approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member
@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@huan huan merged commit 35bf5b8 into wechaty:master Sep 30, 2019
@su-chang su-chang deleted the patch-2 branch October 8, 2019 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
< 3E50 create-branch data-default-repo="wechaty/wechaty" data-selected-nwo="wechaty/wechaty" data-default-source-branch="main" data-sidebar-url="/wechaty/wechaty/issues/closing_references/partials/sidebar?source_id=500154485&source_type=ISSUE" class="discussion-sidebar-item d-block">
Development

Successfully merging this pull request may close these issues.
2 participants
@su-chang @huan
0