Show LoTW confirmed gridsquare even if not updated in DB #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #324 we implemented a check whether the LotW confirmed square is more precise than the one we already have in the log. If that it not the case we do not update the gridsquare. As a side effect the (not-updated) gridsquare is not shown in the results of a (manual) LoTW sync:
In this case the grids which were confirmed on LoTW were already in the log. But the results pretend that there was no grid (confirmed). This fixes the issue so that the already confirmed grid is shown in case it is already in the log: