added expiration index, upgrade deprecating method #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
dynamodb.pyandmongodb.pycache libraries, as well as their corresponding tests. The changes focus on updating the method for obtaining the current UTC time and ensuring the creation of an expiration index in MongoDB.Changes to datetime handling:
src/cachelib/dynamodb.py: Modified the_utcnowmethod to usedatetime.now(datetime.UTC)instead ofdatetime.utcnow()for obtaining the current UTC time.src/cachelib/mongodb.py: Modified the_utcnowmethod to usedatetime.now(datetime.UTC)instead ofdatetime.utcnow()for obtaining the current UTC time.Changes to MongoDB index creation:
src/cachelib/mongodb.py: Added a check to create an index on the "expiration" field if it does not already exist.tests/test_mongodb_cache.py: Added an assertion to verify the creation of the "expiration" index in the MongoDB cache tests.<!--Before opening a PR, open a ticket describing the issue or feature the PR will address. Follow the steps in CONTRIBUTING.rst.
Replace this comment with a description of the change. Describe how it addresses the linked ticket.
-->
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.