8000 Expand interp cart grid testing by djps · Pull Request #574 · waltsims/k-wave-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Expand interp cart grid testing #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 90 commits into
base: master
Choose a base branch
from
Open

Expand interp cart grid testing #574

wants to merge 90 commits into from

Conversation

djps
Copy link
Collaborator
@djps djps commented Mar 20, 2025

This extends the tests for ìnterp_cart_grid` so that different sensor data is stored at different positions.

@waltsims
Copy link
Owner

Related to #572

@waltsims waltsims force-pushed the expand_interp_cart_grid_testing branch from e51338a to 290c1d3 Compare March 28, 2025 03:14
@waltsims waltsims force-pushed the expand_interp_cart_grid_testing branch from 1cedec5 to 8974a47 Compare March 28, 2025 04:38
@codecov Codecov

This comment was marked as outdated.

Sign in to view
@djps
Copy link
Collaborator Author
djps commented May 6, 2025

I have no idea why ruff/isort is not working, although it doesn't matter too much.

Have have increased the test coverage for interp_cart_data,

@djps djps closed this May 6, 2025
@djps djps reopened this May 6, 2025
@djps
Copy link
Collaborator Author
djps commented May 6, 2025

ok, i have absolutely no idea why ruff/isort fails and although it is not important, i would like to know why.

As for the test coverage - I am not sure where the motifications of interp_cart_data come from, but there are tests which help maintain the code coverage but don't actually ensure the code is tested, for example test_interp_cart_data_2_points_linear in test_utils.py. I had put a pytest.skip pragma in to stop them running as it is gives a false impression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@faridyagubbayli faridyagubbayli Awaiting requested review from faridyagubbayli

@waltsims waltsims Awaiting requested review from waltsims

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djps @waltsims
0