8000 🐛 import function `waitAll` by xuanyanwow · Pull Request #918 · walkor/workerman · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🐛 import function waitAll #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2023
Merged

🐛 import function waitAll #918

merged 1 commit into from
Jun 12, 2023

Conversation

xuanyanwow
Copy link
Contributor

你好,发现在你之前移除 import function 的修改中错误删除了waitAll的引入,另外还有以下疑问

  • 需要移除 import function 的原因是什么,别的包可能有跟全局函数同名冲突
  • 希望可以引入标准工具增强项目代码质量,如cs-fixer,phpstan

@xuanyanwow xuanyanwow changed the title 🐛 import function watiAll 🐛 import function waitAll Jun 12, 2023
@walkor walkor merged commit 7dea1e6 into walkor:master Jun 12, 2023
@walkor
Copy link
Owner
walkor commented Jun 12, 2023

可能是误操作
关于cs-fixer, phpstan 欢迎pr

@huangdijia
Copy link

发个版本?

@walkor
Copy link
Owner
walkor commented Jun 12, 2023

已发,v5.0.0-beta.6

@huangdijia
Copy link

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0