Update Worker.php #742
Merged
Update Worker.php #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mowangjuanzi
commented
Apr 1, 2022
| @@ -589,10 +588,10 @@ protected static function init() | |||
| if (empty(static::$logFile)) { | |||
| static::$logFile = __DIR__ . '/../../workerman.log'; | |||
| } | |||
| $log_file = (string)static::$logFile; | |||
There was a problem hiding this comment.
@walkor 这里我不知道你为啥要强制转成 string，但是我看现有的代码，赋值都是 string，所以就移除了。你看看，如果有问题，就改呀
There was a problem hiding this comment.
$logFile可能是个支持__toString()方法的对象，__toString()方法里可按照某种规则转换成不同的路径，比如按照日期转换路径。
There was a problem hiding this comment.
ok。
我编写了这么一条DEMO。
<?php
echo "current PHP version: " . PHP_VERSION . "\r\n";
class Demo {
public function __toString()
{
return "hello.log";
}
}
$demo = new Demo();
echo "log name: " . $demo . "\r\n";
if (!is_file($demo)) {
echo "log file is not exists.\r\n";
\touch($demo);
\chmod($demo, 0622);
}然后使用如下命令运行：
$ sudo docker run -it --rm --name my-running-script -v "$PWD":/usr/src/myapp -w /usr/src/myapp php:7.0-cli php demo1.php
current PHP version: 7.0.33
log name: hello.log
log file is not exists.
$ ll ./hello.log
-rw--w--w- 1 root root 0 4月 1 23:13 ./hello.log所以我认为这么修改，即便传入对象，那也是ok的。
|
好的
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
常规优化