interp: Improve colors when using light background #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thushan hey! could you give this a spin in windows and see if colors looks ok in cmd and the new terminal thingy? |
|
Windows Terminal test (built from master 5af1174) Dark Light vs v0.8.0: Dark Light This is probably an extreme example because I have Windows Terminal + Starship + dark themes, so the light theme isn't properly configured, but alas this does fix it :) |
|
Thanks a lot! I should really get myself a windows dev env somehow, used to virtualized one but was slow pain to use. Seems to look fine. A bit weird that neither before (brightwhite) or after (defaultgb+bold) the lightest white made any difference. Maybe a theme thing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #729