8000 Handling of invalid properties · Issue #1673 · w3c/epub-specs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of invalid properties #1673

Closed
mattgarrish opened this issue May 12, 2021 · 6 comments · Fixed by #1670
Closed

Handling of invalid properties #1673

mattgarrish opened this issue May 12, 2021 · 6 comments · Fixed by #1670
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation

Comments

@mattgarrish
Copy link
Member

For the property data type, we say Reading System concatenation of the base URL and value must result in a valid url string.

So what happens if it doesn't? Must Reading Systems ignore the value? Should they ignore it? Or do we not care?
@mattgarrish mattgarrish added the Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation label May 12, 2021
@iherman
Copy link
Member
iherman commented May 12, 2021

My vote would be to ignore the value (and, possibly, issue a warning)

@dauwhe dauwhe added the Agenda+ Issues that should be discussed during the next working group call. label May 12, 2021
@mattgarrish mattgarrish mentioned this issue May 13, 2021
Merged
@bduga
Copy link
Collaborator
bduga commented May 13, 2021

Where is the current conformance language? I am somehow not seeing it.

@mattgarrish
Copy link
Member Author

Current language is here: https://w3c.github.io/epub-specs/epub33/rs/#sec-property-datatype

Updated language in the open PR is here: https://cdn.statically.io/gh/w3c/epub-specs/fix/issue-808/epub33/rs/index.html#sec-property-datatype

@iherman
Copy link
Member
iherman commented May 14, 2021

The issue was discussed in a meeting on 2021-05-13

List of resolutions:

View the transcript

7. Handling of invalid properties

See github issue #1673.

Matt Garrish: when I was making the URL spec change this came up
… when property values expand, they are supposed to expand into valid URL string
… assuming that if it is invalid, then RS should ignore property

Brady Duga: there are also situations where RS is suppose to ignore in failure case

Dave Cramer: right, this causes as little disruption to reading experience as possible
… e.g. not doing something to alert the reader

Proposed resolution: If a property is invalid, ignore it, close issue 1673 (Wendy Reid)

Ben Schroeter: +1

Shinya Takami (高見真也): +1

Brady Duga: +1

Matt Garrish: +1

Dave Cramer: +1

Matthew Chan: +1

Fred Chasen: +1

Toshiaki Koike: +1

Wendy Reid: +1

Resolution #3: If a property is invalid, ignore it, close issue 1673

@iherman
Copy link
Member
iherman commented May 14, 2021

@mattgarrish I did not know whether you want to change something on the spec related to this, so I did not close this issue yet.

@iherman iherman removed the Agenda+ Issues that should be discussed during the next working group call. label May 14, 2021
@mattgarrish
Copy link
Member Author

Also will close automatically with #1650. I've added the statement to the updated section on expanding property data types (as linked in the above comment).

@mattgarrish mattgarrish added the EPUB33 Issues addressed in the EPUB 3.3 revision label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-ReadingSystems The issue affects the EPUB Reading Systems 3.3 Recommendation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change to using URL standard w3c/epub-specs
4 participants
@iherman @mattgarrish @bduga @dauwhe
0