-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-values-4] initial work on vhc unit proposal text. Resolves #4329 #5108
Conversation
I don't think `vhc` is (or should be) the final unit's name; however, I did want to start working on the text for this new unit, and then we can swap out the name at a later time.
@frehner you should have gotten an email from someone at the W3C about intellectual property commitments |
I haven't received anything yet as far as I can tell. I also just checked my spam folder just in case |
I created and linked my w3c account to my github account. However, I'm not entirely sure if I need to do more (e.g. join the csswg? and can I do that if I'm not part of a sponsor company?) |
For the name, I like the |
Won't When chrome is hidden, the visual viewport will refer to the screen with chrome hidden, but |
I don't understand what you are mentioning about |
The draft is clarifying that 1 Both values are defined in terms of the layout / fixed viewport. Above there are three screenshots from a simulated iphone. Left: UA Chrome at smallest size Middle: UA Chrome at largest size Right: With scale The height of the visual viewport will some times be equal Maybe @bokand can weigh in here? |
@johannesodland That doesn't seem to be my interpretation of how Is our conflicting interpretations the confusion part? Because if what happens is actually your interpretation, this new property being suggested is, for the most part, barely useful at all. |
@brunoais I think our interpretations are definitely different. This PR specs a vhc unit as folows:
As I interpret it it, this viewport unit is defined relative to the ICB and will only change when a window is resized and the ICB changes size. It is stable and does not change when UA chrome changes size. (It will be 635px on the iPhone in my example, as long as the phone is not rotated.) If the unit changed with the UA chrome we would get all the reflow issues that we had with vh earlier. Having this unit in addition to vh is very useful, at least for us. It allows us to use css to style content that fits inside the browser chrome without using JS. Viewport units matching the visual viewport could be useful too as a way to reference the visual viewport API values in CSS, but as I read the original issue and the PR this unit is defined relative to the ICB. |
This is the correct interpretation of the vhc unit. Having a value that changes causes issues with rendering; see the discussion in the issue for details. |
Ok. Definitely my bad. Then I guess I will try to come up with another proposal that does as I remembered. |
Sounds great! When you make it, link to it from the original issue if you don’t mind! I would love to follow it. |
@frehner CSS Values 4 has logical viewport-percentage lengths |
Seems like they should, yes. I'm not sure if here or the related issue would be the place to bring that up with the WG though. |
You’re right. I’ll bring it up in th issue 👍🏼 |
Hi @frehner ! @tabatkins and I committed 0f78ba4 as a replacement of this PR. Not that there was anything specifically wrong with yours, it was a good set of edits! But we needed a lot more detail in the spec, and also a bit of restructuring seemed necessary, so I'm going to close out this PR without accepting. We did add your name to the Acknowledgements section, though, to say thanks for your efforts on this issue. ;) You did a great job of channeling the discussion and helping to make this happen. <3 |
Thank you both so much; I’m excited to see progress, and honestly it it makes me a little giddy to see my name in there as well. 😃 |
Resolves #4329
I don't think
vhc
is (or should be) the final unit's name; however, I did want to start working on the text for this new unit, and then we can swap out once that's decided.This is my first time proposing changes to the spec, so I probably did something wrong. Let me know and I'll fix it :)