This repository was archived by the owner on Jul 1, 2021. It is now read-only.
Drop End-Of-Life ruby versions #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop support for rubies older than 2.4.
|
Looks like the tests aren't showing up in the "checks" here anymore, but it is green https://travis-ci.org/github/vmware/rbvmomi/builds/708774222 |
|
Hey @jrgarcia what do you think? |
|
I definitely want to do this, but let me think a bit. I'm going to need to bump to a new major version after this to prevent issues with people on older EOL Ruby versions (though honestly, why? 😅). I'll try and do this tomorrow or Friday. Thanks so much for this! |
|
Thanks so much for this! Just pushed rbvmomi v3 to RubyGems with these changes. |
|
My pleasure @jrgarcia !! Thanks for the merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for rubies older than 2.4. Technically 2.4 is EOL but jruby-9.2.12.0 fails without ruby 2.4.1 [link]
#162