[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ROCm load format check #10767

Merged

Conversation

wangxiyuan
Copy link
Contributor
@wangxiyuan wangxiyuan commented Nov 29, 2024

The value of rocm_not_supported_load_format is kept be empty for all most one year from #2180. I assume this check is not needed now.

This PR clean up the related check code. Once the check is need again in the future, the better way is to move to platform module instead.

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

@kewang-xlnx do you have more context regarding this?

@kewang-xlnx
Copy link

@kewang-xlnx do you have more context regarding this?

Actually, What I know is that ROCm already supports the FP8 format and plans to support the Quark format. For unsupported formats, I am not clear at the moment. @charlifu Do you have more context regarding this?

@wangxiyuan
Copy link
Contributor Author

Any feedback? How about clean up the code first. If it still need, we can add it back into platformt module instead. @DarkLight1337 @charlifu

@charlifu
Copy link
Contributor
charlifu commented Dec 3, 2024

I think it should be ok to land this first.

@DarkLight1337 DarkLight1337 self-requested a review December 4, 2024 02:35
@DarkLight1337
Copy link
Member

Thanks for verifying, let's get this merged then.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 4, 2024 02:35
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 4, 2024
@DarkLight1337 DarkLight1337 merged commit b5b647b into vllm-project:main Dec 4, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants