8000 [plugin-applitools] Support applitools accessibility testing by uarlouski · Pull Request #3948 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[plugin-applitools] Support applitools accessibility testing #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2023
Merged

[plugin-applitools] Support applitools accessibility testing #3948

merged 2 commits into from
May 22, 2023

Conversation

uarlouski
Copy link
Member

No description provided.

@uarlouski uarlouski requested a review from a team as a code owner May 17, 2023 10:24
@uarlouski uarlouski requested review from valfirst and ikalinin1 May 17, 2023 10:24
@uarlouski uarlouski force-pushed the applitools-accessibility branch from 5554a9f to de7deaa Compare May 17, 2023 10:59
@codecov
Copy link
codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #3948 (6789157) into master (a519417) will increase coverage by 7.89%.
The diff coverage is 97.10%.

❗ Current head 6789157 differs from pull request most recent head b716695. Consider uploading reports for the commit b716695 to get more accurate results

@@             Coverage Diff              @@
##             master    #3948      +/-   ##
============================================
+ Coverage     89.28%   97.17%   +7.89%     
+ Complexity     6493     6290     -203     
============================================
  Files           872      875       +3     
  Lines         17995    18043      +48     
  Branches       1172     1176       +4     
============================================
+ Hits          16066    17533    +1467     
+ Misses         1802      405    -1397     
+ Partials        127      105      -22
Impacted Files Coverage Δ
...us/visual/eyes/model/AccessibilityCheckResult.java 85.71% <85.71%> (ø)
.../org/vividus/visual/steps/AbstractVisualSteps.java 100.00% <100.00%> (ø)
...g/vividus/visual/eyes/AbstractApplitoolsSteps.java 100.00% <100.00%> (ø)
...rc/main/java/org/vividus/visual/eyes/UfgSteps.java 100.00% <100.00%> (ø)
...va/org/vividus/visual/eyes/VisualTestingSteps.java 100.00% <100.00%> (ø)
...xamplesTableToApplitoolsVisualChecksConverter.java 100.00% <100.00%> (ø)
...verter/StringToAccessibilitySettingsConverter.java 100.00% <100.00%> (ø)
...vidus/visual/eyes/model/ApplitoolsTestResults.java 100.00% <100.00%> (ø)
...visual/eyes/model/ApplitoolsVisualCheckResult.java 100.00% <100.00%> (ø)
...visual/eyes/service/ImageVisualTestingService.java 100.00% <100.00%> (ø)

... and 72 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uarlouski uarlouski force-pushed the applitools-accessibility branch 4 times, most recently from 712dcdc to 5709878 Compare May 19, 2023 13:26
@uarlouski uarlouski force-pushed the applitools-accessibility branch from 5709878 to f3af447 Compare May 20, 2023 15:23
@uarlouski uarlouski force-pushed the applitools-accessibility branch from f3af447 to ac2adfd Compare May 20, 2023 15:48
@uarlouski uarlouski requested a review from valfirst May 21, 2023 10:41
@ikalinin1
Copy link
Member

@uarlouski In general LGTM! I think it makes sense to add examples of accessibility usage in the docs

valfirst
valfirst requested changes May 22, 2023
View reviewed changes
@uarlouski uarlouski force-pushed the applitools-accessibility branch from ac2adfd to e37c09d Compare May 22, 2023 10:33
@uarlouski uarlouski requested a review from valfirst May 22, 2023 10:35
@uarlouski uarlouski force-pushed the applitools-accessibility branch from e37c09d to 6789157 Compare May 22, 2023 12:15
@uarlouski uarlouski force-pushed the applitools-accessibility branch from 6789157 to b716695 Compare May 22, 2023 12:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.6% 97.6% Coverage
0.0% 0.0% Duplication

@uarlouski uarlouski requested a review from valfirst May 22, 2023 12:48
@valfirst valfirst merged commit 70591d9 into master May 22, 2023
@valfirst valfirst deleted the applitools-accessibility branch May 22, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@ikalinin1 ikalinin1 ikalinin1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uarlouski @ikalinin1 @valfirst
0