8000 [extension-selenium] Add ability to check WebDriver capabilities at cloud session link publishing by valfirst · Pull Request #3824 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[extension-selenium] Add ability to check WebDriver capabilities at cloud session link publishing #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

[extension-selenium] Add ability to check WebDriver capabilities at cloud session link publishing #3824

merged 1 commit into from
Apr 13, 2023

Conversation

valfirst
Copy link
Collaborator

The capabilities attempted to get by SauceLabs plugin after WebDriver quit are unavailable, such attempts leads to start of invalid sessions.

sl-error

@valfirst
[extension-selenium] Publish cloud session link before WebDriver quit…
e2d61d3 
… to collect capabilities

The capabilities attempted to get by SauceLabs plugin after WebDriver quit are unavailable, such attempts leads to start of invalid sessions.
@valfirst valfirst requested a review from a team as a code owner April 12, 2023 14:15
@valfirst valfirst requested review from ikalinin1 and uarlouski April 12, 2023 14:15
@codecov
Copy link
codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Merging #3824 (e2d61d3) into master (87a31dd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3824      +/-   ##
============================================
- Coverage     97.05%   97.05%   -0.01%     
+ Complexity     6326     6106     -220     
============================================
  Files           848      848              
  Lines         17439    17439              
  Branches       1139     1139              
============================================
- Hits          16926    16925       -1     
- Misses          407      408       +1     
  Partials        106      106
Impacted Files Coverage Δ
...selenium/cloud/AbstractCloudTestLinkPublisher.java 94.11% <ø> (-0.17%) ⬇️
...ividus/lambdatest/LambdaTestTestStatusManager.java 100.00% <ø> (ø)
.../vividus/saucelabs/SauceLabsTestStatusManager.java 100.00% <ø> (ø)
...n/java/org/vividus/selenium/WebDriverProvider.java 100.00% <100.00%> (ø)
...selenium/cloud/AbstractCloudTestStatusManager.java 92.30% <100.00%> (-0.55%) ⬇️
...vidus/selenium/event/BeforeWebDriverQuitEvent.java 100.00% <100.00%> (ø)
...us/browserstack/BrowserStackTestStatusManager.java 100.00% <100.00%> (ø)
...idus/crossbrowsertesting/CbtTestStatusManager.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 99d5b1f into master Apr 13, 2023
@valfirst valfirst deleted the publish-cloud-session-link-before-web-driver-quit-to-collect-capabilities branch April 13, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uarlouski uarlouski uarlouski approved these changes

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valfirst @uarlouski
0