[plugin-web-app] Introduce OS independent `CONTROL` key #3800

valfirst · 2023-04-04T11:59:11Z

No description provided.

codecov · 2023-04-04T12:17:13Z

Codecov Report

Merging #3800 (f2841fb) into master (7911bef) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3800      +/-   ##
============================================
+ Coverage     96.99%   97.01%   +0.01%     
- Complexity     6083     6095      +12     
============================================
  Files           851      849       -2     
  Lines         17449    17429      -20     
  Branches       1134     1136       +2     
============================================
- Hits          16925    16908      -17     
+ Misses          418      415       -3     
  Partials        106      106

Impacted Files	Coverage Δ
.../vividus/mobileapp/steps/ActionsSequenceSteps.java	`100.00% <ø> (ø)`
...org/vividus/steps/ui/web/ActionsSequenceSteps.java	`100.00% <ø> (ø)`
.../main/java/org/vividus/ui/action/AtomicAction.java	`100.00% <100.00%> (ø)`
...ava/org/vividus/ui/action/AtomicActionFactory.java	`100.00% <100.00%> (ø)`
...i/converter/ParametersToAtomicActionConverter.java	`100.00% <100.00%> (ø)`
...vividus/ui/steps/AbstractActionsSequenceSteps.java	`100.00% <100.00%> (ø)`
.../mobileapp/action/MobileAtomicActionFactories.java	`100.00% <100.00%> (ø)`
...rc/main/java/org/vividus/selenium/KeysManager.java	`100.00% <100.00%> (ø)`
...n/java/org/vividus/steps/ui/web/KeyboardSteps.java	`100.00% <100.00%> (ø)`
...n/java/org/vividus/ui/web/action/FieldActions.java	`98.03% <100.00%> (ø)`
... and 1 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

uarlouski · 2023-04-05T06:59:35Z

vividus-plugin-web-app/src/main/java/org/vividus/ui/web/action/WebAtomicActionFactories.java

+        notEmpty(keys, "At least one key should be provided");
+        for (String key : keys)
+        {
+            actionBuilder.accept(key.length() == 1 ? key : keysManager.convertToKey(true, key));


why don't we perform key validation in case of one key?

this logic was here before:

vividus/vividus-plugin-web-app/src/main/java/org/vividus/ui/web/action/WebSequenceActionType.java

Lines 198 to 213 in c01f672

private static void buildKeysActions(List<String> keys, Consumer<CharSequence> actionBuilder)

{

notEmpty(keys, "At least one key should be provided");

for (String key : keys)

{

if (key.length() == 1)

{

actionBuilder.accept(key);

}

else

{

isTrue(EnumUtils.isValidEnum(Keys.class, key), "The '%s' is not allowed as a key", key);

actionBuilder.accept(Keys.valueOf(key));

}

}

}

uarlouski · 2023-04-05T07:05:31Z

docs/modules/plugins/partials/plugin-web-app-steps.adoc

+[source,gherkin]
+----
+When I execute sequence of actions:
+|type      |argument  |


please align the table :)

sonarqubecloud · 2023-04-05T08:13:39Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

100.0% Coverage
0.0% Duplication

valfirst requested a review from a team as a code owner April 4, 2023 11:59

valfirst requested review from ikalinin1 and uarlouski April 4, 2023 11:59

valfirst marked this pull request as draft April 4, 2023 11:59

valfirst force-pushed the introduce-os-independent-control branch from da6184b to 78d47a4 Compare April 4, 2023 13:52

[plugin-web-app] Introduce OS independent CONTROL key

f5b228e

valfirst force-pushed the introduce-os-independent-control branch from 78d47a4 to f5b228e Compare April 4, 2023 14:42

valfirst marked this pull request as ready for review April 4, 2023 15:02

uarlouski reviewed Apr 5, 2023

View reviewed changes

uarlouski approved these changes Apr 5, 2023

View reviewed changes

[docs] Fix formatting of examples

f2841fb

valfirst merged commit c5b4978 into master Apr 5, 2023

valfirst deleted the introduce-os-independent-control branch April 5, 2023 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[plugin-web-app] Introduce OS independent `CONTROL` key #3800

[plugin-web-app] Introduce OS independent `CONTROL` key #3800

	private static void buildKeysActions(List<String> keys, Consumer<CharSequence> actionBuilder)
	{
	notEmpty(keys, "At least one key should be provided");
	for (String key : keys)
	{
	if (key.length() == 1)
	{
	actionBuilder.accept(key);
	}
	else
	{
	isTrue(EnumUtils.isValidEnum(Keys.class, key), "The '%s' is not allowed as a key", key);
	actionBuilder.accept(Keys.valueOf(key));
	}
	}
	}

[plugin-web-app] Introduce OS independent CONTROL key #3800

[plugin-web-app] Introduce OS independent CONTROL key #3800

Conversation

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

[plugin-web-app] Introduce OS independent `CONTROL` key #3800

[plugin-web-app] Introduce OS independent `CONTROL` key #3800