8000 Make resource validation fail-fast safety by draker94 · Pull Request #3791 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make resource validation fail-fast safety #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2023
Merged

Make resource validation fail-fast safety #3791

merged 1 commit into from
Apr 17, 2023

Conversation

draker94
Copy link
Contributor
@draker94 draker94 commented Mar 31, 2023 •
edited
Loading

Closes #3780

@draker94 draker94 requested a review from a team as a code owner March 31, 2023 16:08
@draker94 draker94 marked this pull request as draft April 3, 2023 08:01
@draker94 draker94 force-pushed the fix_resource_checker_thread_execution branch from f7c0d1a to ae619a6 Compare April 3, 2023 14:52
@draker94 draker94 marked this pull request as ready for review April 3, 2023 14:55
@draker94 draker94 force-pushed the fix_resource_checker_thread_execution branch from ae619a6 to 99df3bb Compare April 4, 2023 11:39
@draker94 draker94 marked this pull request as draft April 5, 2023 10:06
@draker94 draker94 force-pushed the fix_resource_checker_thread_execution branch 2 times, most recently from 11d7e4a to 61b772b Compare April 5, 2023 17:31
@draker94 draker94 marked this pull request as ready for review April 5, 2023 17:53
@codecov
Copy link
codecov bot commented Apr 5, 2023 •
edited
Loading

Codecov Report

Merging #3791 (9670c3c) into master (42a1cc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #3791   +/-   ##
=========================================
  Coverage     97.06%   97.06%           
- Complexity     6108     6111    +3     
=========================================
  Files           848      848           
  Lines         17449    17473   +24     
  Branches       1139     1141    +2     
=========================================
+ Hits          16936    16961   +25     
  Misses          407      407           
+ Partials        106      105    -1
Impacted Files Coverage Δ
...ividus/steps/http/HttpResourceValidationSteps.java 100.00% <100.00%> (ø)
.../vividus/steps/integration/ResourceCheckSteps.java 100.00% <100.00%> (ø)
...c/main/java/org/vividus/softassert/SoftAssert.java 92.10% <100.00%> (+1.82%) ⬆️
...vividus/softassert/JBehaveFailTestFastManager.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@draker94 draker94 force-pushed the fix_resource_checker_thread_execution branch from 61b772b to dbcaee6 Compare April 6, 2023 07:46
valfirst
valfirst requested changes Apr 6, 2023
View reviewed changes
@draker94 draker94 force-pushed the fix_resource_checker_thread_execution branch 4 times, most recently from a59723c to 5fd6712 Compare April 12, 2023 06:57
@draker94 draker94 force-pushed the fix_resource_checker_thread_execution branch from 5fd6712 to cb3738a Compare April 13, 2023 12:47
@draker94 draker94 changed the title Make resource validation thread and fail safety Make resource validation fail-fast safety Apr 13, 2023
@draker94 draker94 force-pushed the fix_resource_checker_thread_execution branch from cb3738a to 9670c3c Compare April 14, 2023 07:19
@valfirst valfirst merged commit 792c5fe into vividus-framework:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@uarlouski uarlouski uarlouski approved these changes

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource validation steps don't work correctly with scenario fail-fast
4 participants
@draker94 @valfirst @uarlouski @web-flow
0