8000 [extension-selenium] Add possibility to set context without resetting… by ikalinin1 · Pull Request #2566 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[extension-selenium] Add possibility to set context without resetting… #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2022
Merged

[extension-selenium] Add possibility to set context without resetting… #2566

merged 1 commit into from
Mar 21, 2022

Conversation

ikalinin1
Copy link
Member

… current one

@codecov
Copy link
codecov bot commented Mar 12, 2022 •
edited
Loading

Codecov Report

Merging #2566 (1b6989c) into master (3079e5d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #2566   +/-   ##
=========================================
  Coverage     96.59%   96.60%           
- Complexity     5503     5508    +5     
=========================================
  Files           779      780    +1     
  Lines         15819    15850   +31     
  Branches       1045     1047    +2     
=========================================
+ Hits          15281    15312   +31     
  Misses          414      414           
  Partials        124      124
Impacted Files Coverage Δ
...a/org/vividus/steps/ui/GenericSetContextSteps.java 100.00% <100.00%> (ø)
...rc/main/java/org/vividus/steps/VariablesSteps.java 100.00% <0.00%> (ø)
...ain/java/org/vividus/steps/ui/web/NestedSteps.java 100.00% <0.00%> (ø)
...rg/vividus/publishing/DiffAttachmentPublisher.java 100.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

valfirst
valfirst requested changes Mar 12, 2022
View reviewed changes
docs/modules/plugins/partials/generic-ui-steps.adoc Outdated
@@ -176,6 +176,25 @@ Then `${numberOfLinks}` is equal to `1`

Changes the context to an element located by locator for limiting area of subsequent UI interactions.

[source,gherkin]
----
When I change context to element located `$locator` using current context
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When I change context to element located `$locator` using current context
When I change context to element located `$locator` in scope of current context

?

@ikalinin1 ikalinin1 force-pushed the context_wo_reset branch 2 times, most recently from 675d152 to 205cc92 Compare March 14, 2022 11:27
@ikalinin1 ikalinin1 requested a review from valfirst March 15, 2022 14:04
@ikalinin1 ikalinin1 requested review from valfirst and uarlouski March 16, 2022 10:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 3afb37c into master Mar 21, 2022
@valfirst valfirst deleted the context_wo_reset branch March 21, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@uarlouski uarlouski uarlouski approved these changes

@abudevich abudevich Awaiting requested review from abudevich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikalinin1 @valfirst @uarlouski
0