[vividus] Publish unified diff for strings comparison #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportMerging #2564 (6f0bc04) into master (4758abd) will increase coverage by @@ Coverage Diff @@
## master #2564 +/- ##
==========================================
Coverage 96.59% 96.60%
+ Complexity 5682 5503 -179
==========================================
Files 779 780 +1
Lines 15819 15844 +25
Branches 1045 1047 +2
==========================================
+ Hits 15281 15306 +25
Misses 414 414
Partials 124 124
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
valfirst
requested changes
Mar 11, 2022
valfirst
requested changes
Mar 16, 2022
|
|
||
| |`report.text-length-diff-threshold` | ||
| |`100` | ||
| |Defines text threshold length to enable unified diff report publishing on failure, for variable comparisons |
There was a problem hiding this comment.
I think it makes sense to move this description to the relevant steps to make it transparent for users.
There was a problem hiding this comment.
We don't have docs for the step, isn't it out of scope this PR ? :)
valfirst
reviewed
Mar 16, 2022
vividus/src/main/java/org/vividus/publishing/DiffAttachmentPublisher.java
Show resolved
Hide resolved
valfirst
approved these changes
Mar 17, 2022
uarlouski
approved these changes
Mar 17, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2584
