8000 [vividus] Consider system hooks status at exit code calculation by valfirst · Pull Request #2467 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[vividus] Consider system hooks status at exit code calculation #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

8000 Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

[vividus] Consider system hooks status at exit code calculation #2467

merged 1 commit into from
Feb 11, 2022

Conversation

valfirst
Copy link
Collaborator

Fixes #2465
Relates #2411

@codecov
Copy link
codecov bot commented Feb 11, 2022 •
edited
Loading

Codecov Report

Merging #2467 (82083f1) into master (19f2f11) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2467   +/-   ##
=========================================
  Coverage     96.58%   96.58%           
  Complexity     5470     5470           
=========================================
  Files           773      773           
  Lines         15721    15726    +5     
  Branches       1044     1044           
=========================================
+ Hits          15184    15189    +5     
  Misses          414      414           
  Partials        123      123
Impacted Files Coverage Δ
...src/main/java/org/vividus/StatusStoryReporter.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7d394...82083f1. Read the comment docs.

@valfirst valfirst force-pushed the fix-reporting-of-system-hooks branch from 1c74e58 to 82083f1 Compare February 11, 2022 14:36
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 1b567e8 into master Feb 11, 2022
@valfirst valfirst deleted the fix-reporting-of-system-hooks branch February 11, 2022 15:41
VitaliaPiliuhina pushed a commit to VitaliaPiliuhina/vividus that referenced this pull request Apr 8, 2022
@valfirst
[vividus] Consider system hooks status at exit code calculation (vivi…
965b920 
…dus-framework#2467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikalinin1 ikalinin1 ikalinin1 approved these changes

@uarlouski uarlouski uarlouski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build successful with the failing tests inside
3 participants
@valfirst @ikalinin1 @uarlouski
0