Restrict TestResourceLoader from search of non-classpath resources in subfolders #2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2421 +/- ##
=========================================
Coverage 96.40% 96.40%
Complexity 5439 5439
=========================================
Files 772 772
Lines 15641 15644 +3
Branches 1046 1046
=========================================
+ Hits 15078 15081 +3
Misses 439 439
Partials 124 124
Continue to review full report at Codecov.
|
uarlouski
reviewed
Jan 28, 2022
| else | ||
| { | ||
| locationPattern = CLASSPATH_ALL_URL_PREFIX + normalizedResourceLocation; | ||
| allResources = resourcePatternResolver.getResources(locationPattern + "**/" + resourcePattern); |
There was a problem hiding this comment.
@valfirst as I see in default behavior we add **/, but should not the user be responsible for adding this into resource pattern on his own?
There was a problem hiding this comment.
tricky question, but "backward compatibility" is our goal
valfirst
reviewed
Jan 28, 2022
vividus-engine/src/main/java/org/vividus/resource/TestResourceLoader.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Valery Yatsynovich <valfirst@yandex.ru>
ikalinin1
approved these changes
Jan 28, 2022
valfirst
approved these changes
Jan 28, 2022
uarlouski
approved these changes
Jan 28, 2022
ikalinin1
pushed a commit
that referenced
this pull request
Jan 31, 2022
…tem (#2421) Co-authored-by: Dzmitry Targonsky <dzmitry_targonsky@epam.com> Co-authored-by: Valery Yatsynovich <valfirst@yandex.ru>
VitaliaPiliuhina
pushed a commit
to VitaliaPiliuhina/vividus
that referenced
this pull request
Apr 8, 2022
…tem (vividus-framework#2421) Co-authored-by: Dzmitry Targonsky <dzmitry_targonsky@epam.com> Co-authored-by: Valery Yatsynovich <valfirst@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.