8000 [agent-reportportal] Do not report comments by ikalinin1 · Pull Request #2424 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[agent-reportportal] Do not report comments #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2022
Merged

[agent-reportportal] Do not report comments #2424

merged 1 commit into from
Jan 29, 2022

Conversation

ikalinin1
Copy link
Member
@ikalinin1 ikalinin1 commented Jan 28, 2022

Reporting of the comments in any of the available statuses will affect the overall statistics.
fixes #2146

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link
codecov bot commented Jan 28, 2022

Codecov Report

Merging #2424 (8121034) into master (bfa0d58) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2424   +/-   ##
=========================================
  Coverage     96.40%   96.40%           
- Complexity     5439     5440    +1     
=========================================
  Files           772      772           
  Lines         15641    15643    +2     
  Branches       1046     1046           
=========================================
+ Hits          15078    15080    +2     
  Misses          439      439           
  Partials        124      124           
Impacted Files Coverage Δ
...ve/AdaptedDelegatingReportPortalStoryReporter.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa0d58...8121034. Read the comment docs.

@@ -58,4 +58,3 @@ include 'vividus-exporter-commons'

include 'vividus-docker-bundler'
include 'vividus-tests'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it expected?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change bothers me locally as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotless does it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should... abide.. spotlesssss

@ikalinin1 ikalinin1 requested a review from valfirst January 28, 2022 12:52
@valfirst valfirst merged commit ae3f068 into master Jan 29, 2022
@valfirst valfirst deleted the comments branch January 29, 2022 19:58
VitaliaPiliuhina pushed a commit to VitaliaPiliuhina/vividus that referenced this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commented steps marked as failed in ReportPortal
3 participants
0