8000 [plugin-json] Add steps to manipulate JSON element values by valfirst · Pull Request #2337 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[plugin-json] Add steps to manipulate JSON element values #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

valfirst
Copy link
Collaborator
@valfirst valfirst commented Dec 28, 2021

Closes #2114

@valfirst valfirst marked this pull request as draft December 28, 2021 20:20
@codecov
Copy link
codecov bot commented Dec 28, 2021

Codecov Report

Merging #2337 (071f7f9) into master (f6b8c1b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2337      +/-   ##
============================================
+ Coverage     96.32%   96.33%   +0.01%     
- Complexity     5360     5383      +23     
============================================
  Files           762      763       +1     
  Lines         15404    15453      +49     
  Branches       1022     1028       +6     
============================================
+ Hits          14838    14887      +49     
  Misses          442      442              
  Partials        124      124              
Impacted Files Coverage Δ
...va/org/vividus/json/softassert/JsonSoftAssert.java 100.00% <ø> (ø)
...in/java/org/vividus/json/steps/JsonPatchSteps.java 100.00% <ø> (ø)
...rc/main/java/org/vividus/json/steps/JsonSteps.java 100.00% <100.00%> (ø)
...vividus/steps/api/JsonResponseValidationSteps.java 95.95% <100.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b8c1b...071f7f9. Read the comment docs.

@valfirst valfirst force-pushed the add-steps-to-manipulate-json-element-values branch 3 times, most recently from d5bbcf3 to 8e14555 Compare December 29, 2021 10:25
@valfirst valfirst marked this pull request as ready for review December 29, 2021 10:26
@valfirst valfirst force-pushed the add-steps-to-manipulate-json-element-values branch from 8e14555 to 071f7f9 Compare December 29, 2021 12:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

implementation project(':vividus-util')
implementation (group: 'com.flipkart.zjsonpatch', name: 'zjsonpatch', version: '0.4.11')
implementation(group: 'com.jayway.jsonpath', name: 'json-path-assert', version: "${jsonPathVersion}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just jsonPathVersion doesn't work here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK dependabot is not able to handle such values

Examples:
|jsonPath |rule |expected |
|$.store.book[0].category |contains |feren |
!-- |$.store.book[0].isbn |is equal to |null | <- TODO: introduce a new expression #{null}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

introduce a new expression #{null}

@valfirst valfirst merged commit 7462463 into master Dec 30, 2021
@valfirst valfirst deleted the add-steps-to-manipulate-json-element-values branch December 30, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add step, which get json element value
3 participants
0