8000 [extension-selenium] Update screenshot taking step (#1795) by draker94 · Pull Request #2295 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[extension-selenium] Update screenshot taking step (#1795) #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree t 8000 o our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2021
Merged

[extension-selenium] Update screenshot taking step (#1795) #2295

merged 1 commit into from
Dec 20, 2021

Conversation

draker94
Copy link
Contributor
@draker94 draker94 commented Dec 16, 2021 •
edited by valfirst
Loading

Closes #1795.

  • Update screenshot taking step (When I take screenshot) to publish screenshots in the report only.

@codecov
Copy link
codecov bot commented Dec 16, 2021 •
edited
Loading

Codecov Report

Merging #2295 (90ad165) into master (002094d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2295   +/-   ##
=========================================
  Coverage     88.00%   88.00%           
+ Complexity     5545     5544    -1     
=========================================
  Files           762      762           
  Lines         15401    15403    +2     
  Branches       1033     1033           
=========================================
+ Hits          13554    13556    +2     
  Misses         1712     1712           
  Partials        135      135
Impacted Files Coverage Δ
...s/selenium/screenshot/AbstractScreenshotTaker.java 96.42% <ø> (-0.45%) ⬇️
...va/org/vividus/steps/ui/ScreenshotTakingSteps.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002094d...90ad165. Read the comment docs.

@draker94 draker94 force-pushed the update_screenshot_taking_steps branch 2 times, most recently from 06ba10a to 95b1c9d Compare December 17, 2021 13:06
@draker94
[extension-selenium] Update screenshot taking step (vividus-framework…
90ad165 
…#1795)

Update screenshot taking step (`When I take screenshot`) to publish screenshot only in Allure Report.
@draker94 draker94 force-pushed the update_screenshot_taking_steps branch from 95b1c9d to 90ad165 Compare December 18, 2021 11:25
@valfirst valfirst merged commit 11d6501 into vividus-framework:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@ikalinin1 ikalinin1 ikalinin1 approved these changes

@uarlouski uarlouski uarlouski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update screenshot taking step to publish screenshot only in report
4 participants
@draker94 @valfirst @ikalinin1 @uarlouski
0