8000 [plugin-mobile-app] Deprecate web view switching by index by uarlouski · Pull Request #2216 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[plugin-mobile-app] Deprecate web view switching by index #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and con 8000 tact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

uarlouski
Copy link
Member
@uarlouski uarlouski commented Nov 18, 2021

The order of web views returned by Appium is not reliable.

  • For Android platform the web views are retrieved by parsing UNIX socket names from /proc/net/unix.
  • For iOS platform the web views are considered as separate processes within the active application.

Sorting the web view by Inode number for android or PID for iOS doesn't seem logical for end users and as practice shows the order is not guaranteed.

@uarlouski uarlouski force-pushed the deprecate-web-view-by-index branch from 9d478a8 to 8bf4d59 Compare November 18, 2021 13:59
@uarlouski uarlouski requested a review from valfirst November 18, 2021 14:12
@codecov
Copy link
codecov bot commented Nov 18, 2021

Codecov Report

Merging #2216 (a513216) into master (65c6aec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2216   +/-   ##
=========================================
  Coverage     96.23%   96.23%           
  Complexity     5387     5387           
=========================================
  Files           764      764           
  Lines         15443    15444    +1     
  Branches       1027     1027           
=========================================
+ Hits          14862    14863    +1     
  Misses          451      451           
  Partials        130      130           
Impacted Files Coverage Δ
...g/vividus/bdd/mobileapp/steps/SetContextSteps.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c6aec...a513216. Read the comment docs.

The order of web views returned by appium is not reliable.
For android platform the web views are retrieved by parsing UNIX socket names from /proc/net/unix.
For ios platform the web views are consideres as separate processes within the active application.
Sorting the web view by Inode number for android or PID for ios doen't seem logical for end users and as practice shows the order is not guaranteed.
@uarlouski uarlouski force-pushed the deprecate-web-view-by-index branch from 8bf4d59 to a513216 Compare November 19, 2021 08:45
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 8365946 into master Nov 19, 2021
@valfirst valfirst deleted the deprecate-web-view-by-index branch November 19, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0