8000 [plugin-mobile-app] Add long press support for tvOS and iOS by ikalinin1 · Pull Request #2121 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[plugin-mobile-app] Add long press support for tvOS and iOS #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

[plugin-mobile-app] Add long press support for tvOS and iOS #2121

merged 1 commit into from
Oct 29, 2021

Conversation

ikalinin1
Copy link
Member
@ikalinin1 ikalinin1 commented Oct 29, 2021 •
edited by valfirst
Loading

Closes #2087

@ikalinin1 ikalinin1 marked this pull request as draft October 29, 2021 07:52
@codecov
Copy link
codecov bot commented Oct 29, 2021 •
edited
Loading

Codecov Report

Merging #2121 (2cc2d10) into master (ec58b8c) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2121      +/-   ##
============================================
- Coverage     96.20%   96.20%   -0.01%     
- Complexity     5347     5352       +5     
============================================
  Files           756      756              
  Lines         15270    15279       +9     
  Branches       1028     1029       +1     
============================================
+ Hits          14691    14699       +8     
  Misses          450      450              
- Partials        129      130       +1
Impacted Files Coverage Δ
...org/vividus/bdd/mobileapp/steps/KeyboardSteps.java 98.46% <90.90%> (-1.54%) ⬇️
...org/vividus/bdd/steps/ui/web/SetVariableSteps.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec58b8c...2cc2d10. Read the comment docs.

@ikalinin1 ikalinin1 force-pushed the long_press_tvos branch 2 times, most recently from 017ad4c to 2142207 Compare October 29, 2021 09:41
valfirst
valfirst requested changes Oct 29, 2021
View reviewed changes
@ikalinin1 ikalinin1 force-pushed the long_press_tvos branch 2 times, most recently from 90c31a7 to f9ea062 Compare October 29, 2021 12:00
@ikalinin1 ikalinin1 marked this pull request as ready for review October 29, 2021 12:17
uarlouski
uarlouski reviewed Oct 29, 2021
View reviewed changes
vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/KeyboardSteps.java Outdated
}
else if (genericWebDriverManager.isIOS() || genericWebDriverManager.isTvOS())
{
pressButton(key, Map.of("durationSeconds", longPressDuration.toSeconds()));
Copy link
Member
@uarlouski uarlouski Oct 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it better to pass Duration to pressButton to avoid overhead for map creation? Is the durationSeconds 0 by default?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.1% 94.1% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 407cc83 into master Oct 29, 2021
@valfirst valfirst deleted the long_press_tvos branch October 29, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@uarlouski uarlouski uarlouski approved these changes

@abudevich abudevich Awaiting requested review from abudevich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add long press key for tvOS
3 participants
@ikalinin1 @valfirst @uarlouski
0