Fix assertion failure hooks invocation when scenario fail-fast enabled #2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
============================================
+ Coverage 96.15% 96.18% +0.03%
- Complexity 5335 5345 +10
============================================
Files 755 756 +1
Lines 15239 15246 +7
Branches 1026 1028 +2
============================================
+ Hits 14653 14665 +12
+ Misses 453 450 -3
+ Partials 133 131 -2
Continue to review full report at Codecov.
|
f8c696b to
0a925d9
Compare
ikalinin1
approved these changes
Oct 22, 2021
uarlouski
approved these changes
Oct 22, 2021
The order of event subscribers invocation for Guava EventBus is not determined, that fact blocks the ability to put fail-fast mechanism to assertion failure event handler: if fail-fast event handler doesn't go last, the rest assertion failure event handlers (which may be adding application source code etc.) will be invoked in improper system state: the assertion verification is finished, the step is closed in the report.
0a925d9 to
1e67f8d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1989
The order of event subscribers invocation for Guava EventBus is not determined,
that fact blocks the ability to put fail-fast mechanism to assertion failure event handler:
if fail-fast event handler doesn't go last, the rest assertion failure event handlers (which
may be adding application source code etc.) will be invoked in improper system state: the
assertion verification is finished, the step is closed in the report.