8000 Make variables/expressions dry run aware by ikalinin1 · Pull Request #2044 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make variables/expressions dry run aware #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2021
Merged

Make variables/expressions dry run aware #2044

merged 2 commits into from
Oct 5, 2021

Conversation

ikalinin1
Copy link
Member

No description provided.

@ikalinin1 ikalinin1 force-pushed the make_variables_dry_ran_aware branch from 64b80c0 to 908c4dc Compare October 4, 2021 22:04
@ikalinin1 ikalinin1 changed the title Make variables/expressions dry ran aware Make variables/expressions dry run aware Oct 5, 2021
@ikalinin1 ikalinin1 force-pushed the make_variables_dry_ran_aware branch from 908c4dc to ed58bf8 Compare October 5, 2021 06:44
@codecov
Copy link
codecov bot commented Oct 5, 2021 •
edited
Loading

Codecov Report

Merging #2044 (ae231d0) into master (25accac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2044   +/-   ##
=========================================
  Coverage     96.08%   96.08%           
- Complexity     5321     5328    +7     
=========================================
  Files           754      755    +1     
  Lines         15163    15177   +14     
  Branches       1027     1027           
=========================================
+ Hits          14569    14583   +14     
  Misses          460      460           
  Partials        134      134
Impacted Files Coverage Δ
...main/java/org/vividus/bdd/DryRunAwareExecutor.java 100.00% <100.00%> (ø)
.../java/org/vividus/bdd/steps/ExpressionAdaptor.java 100.00% <100.00%> (ø)
...n/java/org/vividus/bdd/steps/VariableResolver.java 100.00% <100.00%> (ø)
...le/ui/AbstractContextProvidingDynamicVariable.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25accac...ae231d0. Read the comment docs.

valfirst
valfirst reviewed Oct 5, 2021
View reviewed changes
Copy link
Collaborator
@valfirst valfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to update/add the documentation to highlight explicitly that expressions & dynamic variables are not resolved at dry run

@ikalinin1 ikalinin1 force-pushed the make_variables_dry_ran_aware branch from ed58bf8 to ae231d0 Compare October 5, 2021 08:47
@ikalinin1 ikalinin1 requested a review from valfirst October 5, 2021 08:53
@sonarqubecloud
Copy link
sonarqubecloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 7703bfe into master Oct 5, 2021
@valfirst valfirst deleted the make_variables_dry_ran_aware branch October 5, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@uarlouski uarlouski uarlouski approved these changes

@abudevich abudevich Awaiting requested review from abudevich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikalinin1 @valfirst @uarlouski
0