8000 [soft-assert] Add ability to set description for known issue by uarlouski · Pull Request #2014 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[soft-assert] Add ability to set description for known issue #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2021
Merged

[soft-assert] Add ability to set description for known issue #2014

merged 1 commit into from
Sep 29, 2021

Conversation

uarlouski
Copy link
Member
@uarlouski uarlouski commented Sep 29, 2021 •
edited by valfirst
Loading

Closes #2011

@uarlouski uarlouski marked this pull request as ready for review September 29, 2021 09:41
@codecov
Copy link
codecov bot commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #2014 (b7662b2) into master (327446b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2014      +/-   ##
============================================
+ Coverage     96.02%   96.09%   +0.06%     
- Complexity     5308     5323      +15     
============================================
  Files           754      754              
  Lines         15161    15168       +7     
  Branches       1029     1030       +1     
============================================
+ Hits          14559    14575      +16     
+ Misses          469      460       -9     
  Partials        133      133
Impacted Files Coverage Δ
...vidus/softassert/formatter/AssertionFormatter.java 94.54% <100.00%> (+0.10%) ⬆️
...vividus/softassert/issue/KnownIssueIdentifier.java 90.00% <100.00%> (+0.81%) ⬆️
.../java/org/vividus/softassert/model/KnownIssue.java 97.05% <100.00%> (+29.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327446b...b7662b2. Read the comment docs.

@uarlouski uarlouski force-pushed the 2011 branch 2 times, most recently from 21ef57b to b4eedee Compare September 29, 2021 13:38
@uarlouski uarlouski requested a review from valfirst September 29, 2021 14:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@uarlouski uarlouski requested a review from valfirst September 29, 2021 14:31
@valfirst valfirst merged commit 9564ac8 into master Sep 29, 2021
@valfirst valfirst deleted the 2011 branch September 29, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@ikalinin1 ikalinin1 ikalinin1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[known-issues] Add possibility to specify comment alongside with the known issue
3 participants
@uarlouski @valfirst @ikalinin1
0